RPP - Connect the duplicate payment prevention service (Verification) #7450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
htdat
commented
Oct 12, 2023
Ref p1697184565184799/1697109799.887649-slack-C05997J5PCG
htdat
force-pushed
the
rpp/7411-duplicate-prevention
branch
from
27d5539 to
e519d52
Compare
htdat
commented
Oct 13, 2023
6 tasks
|
I am going to add tests as well as fix Psalm errors. But it's ready to continue having more reviews. @RadoslavGeorgiev @Automattic/gamma @marcinbot |
RadoslavGeorgiev
requested changes
Oct 25, 2023
There was a problem hiding this comment.
Great work, @htdat! 👏
I essentially only have nitpicks about some spaces here and there, but code-wise this looks great. I'm about to start testing, but wanted to share those first.
Question: Should we call remove_session_processing_order when transitioning from ProcessedState to CompletedState?
RadoslavGeorgiev
requested changes
Oct 25, 2023
tests/unit/src/Internal/Service/DuplicatePaymentPreventionServiceTest.php
Outdated
Show resolved
Hide resolved
tests/unit/src/Internal/Service/DuplicatePaymentPreventionServiceTest.php
Show resolved
Hide resolved
htdat
commented
Oct 25, 2023
|
@RadoslavGeorgiev - thanks for your detailed review. I've addressed all your feedback and resolved most conversations, and keep open for two conversations that you might have other feedback. |
htdat
added
pr: needs author reply
pr: needs review
and removed
pr: needs review
labels
For test_clean_up_when_detecting_duplicate_order
…e to CompletedState
RadoslavGeorgiev
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Excellent work, @htdat!
Thank you for addressing my comments! I went through manual tests as well, and everything worked like a charm.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7411
Changes proposed in this Pull Request
DuplicatePaymentPreventionServiceclass insrcand keep most of logics from the legacy one.srcservice.DuplicateOrderDetectedStatewhen a duplicate order is detected.Intent_Status::AUTHORIZED_STATUSESandis_authorized()for intent abstraction.SessionServiceinsrcwith the purpose of easily handling session data (sometimes, it's null while other times, it's really the expected instance ofWC_Session). This will also be useful when other features will use it, such as Fraud relevant features.srcfiles.Testing instructions
At this stage, we can only test for:
Ensure that you're using the latest versions of Dev Tools and enable New Payment Process Factors.
Ideally, add Xdebug breakpoints in the new code in InitialState.php and the new service php file to confirm new code really executed.
For testing duplicate orders
Basically, follow test instruction and result of this PR #5247 with a note:
For testing duplicate payments
Basically, follow test instruction and result of this PR #5346 with a note:
Remaining TODO(s) for this PR:
N/A
Finished TODOs for this PR
Loggeras dependency per RPP / Housekeeping / Logger #7428check_payment_intent_attached_to_order_succeededandcheck_against_session_processing_order#6712npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge