Detect multiple enabled payment methods of the same type #8513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +487 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
timur27
force-pushed
the
add/duplicates-detection
branch
from
349854f to
f3de0a6
Compare
added 11 commits
March 29, 2024 13:24
timur27
force-pushed
the
add/duplicates-detection
branch
from
1343fda to
d0854b0
Compare
added 10 commits
April 9, 2024 08:33
added 10 commits
April 12, 2024 22:32
…into add/duplicates-detection
timur27
force-pushed
the
add/duplicates-detection
branch
from
82a59a6 to
18d0e08
Compare
timur27
force-pushed
the
add/duplicates-detection
branch
from
18d0e08 to
5e1741a
Compare
timur27
requested review from
a team and
mdmoore
and removed request for
a team
|
@mdmoore I added an optimization in e6a5165 which allows to share the state of dismissed notices between |
timur27
force-pushed
the
add/duplicates-detection
branch
from
934dfbd to
e6a5165
Compare
mdmoore
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
This all LGTM! Only one minor comment about an unused useState hook which GH pointed out.
✅ Navigate to Payments settings and confirm there's an inline notice under credit card payment method. Review extensions should open the WooCommerce payment settings page
✅ Enable any other payment method from APMs list. You can use Klarna gateway to check with Klarna or Stripe for any other payment method.
Confirm that the notice appears.
✅ Test the scenario when a payment method is enabled in three different places, including WooPayments. At this point, you will see the notice. However, if we disable payment method by WooPayments, the notice should disappear, although it's still enabled by two other plugins. The goal is to show the notice only if WooPayments is part of the plugins group that introduce a duplicate.
✅ Check Apple Pay/Google Pay by enabling them e.g. under Stripe gateway and checking if the notice appears. Stripe gateway allows PRBs to be enabled with both disabled and enabled CC, and both use-cases should be covered by this PR.
✅ Dismiss any notice and confirm that it's not shown after closing. Refresh the page and confirm no notice is present.
✅ Confirm that notice is handled separately, meaning that only part of the notices can be dismissed. After such action, the rest should still be present on the page.
All is testing well and I have no critiques here. 🚢
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8384
Changes proposed in this Pull Request
This PR is the first iteration of the feature which should help merchants identify payment methods of the same type that are enabled by multiple plugins. It implements the simple solution mentioned in paJDYF-ck0-p2. The inline notice pops up under the payment method and can be dismissed. Once dismissed, it won't appear again upon page refresh.
For testing steps outlined below, you can use multiple plugins. During development, I used WooPayments, Mollie, Stripe and Klarna). If you'd like to quickly setup Mollie, contact @timur27 for test API keys which hopefully will save you a bit of time. For more inspiration on which plugins you could use, please see paJDYF-ck0-p2#comment-23134 which refers the duplicates data.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge