Reset duplicate notifications from new plugins #8919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +86 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
timur27
force-pushed
the
add/reset-duplicate-notifications-from-new-plugins
branch
from
138f740 to
dd5b853
Compare
…into add/reset-duplicate-notifications-from-new-plugins
…into add/reset-duplicate-notifications-from-new-plugins
timur27
force-pushed
the
add/reset-duplicate-notifications-from-new-plugins
branch
from
631d987 to
af447bc
Compare
timur27
requested review from
a team,
brettshumaker and
mdmoore
and removed request for
a team,
brettshumaker and
mdmoore
|
I re-assigned the review because of the AFKs. |
FangedParakeet
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Code here LGTM and is working as described. I'm trying to think of any edge-cases, whereby an extension, for which we have already dismissed a notice, might reintroduce a duplicated payment method on update or some other mysterious circumstance...but in any case, I think it's a pretty trivial hypothetical and it's hurting my hollow head even thinking too hard about it.
I think this is a really valuable enhancement and I wasn't able to find a way to break it. Nice one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8809
Changes proposed in this Pull Request
This PR ensures that a previously dismissed duplicate notice on the Settings page will reappear if a new plugin triggers duplicates again. This is accomplished by enhancing the dismissed notification object stored in
wp_options. Previously, only the payment method was stored. With this PR, we also store the list of gateway IDs of plugins causing duplicates. This enhancement allows us to handle scenarios where new plugins cause duplicate notices.Testing instructions
class-duplicates-detection-service.phpby keeping onlycardfromstripenow, refresh the Settings pagenpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge