-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall back to credit card when a payment method is toggled off #8909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: +24 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
timur27
changed the title
fallback to cc when payment method is hidden
Fall back to credit card as default payment method when a payment method is toggled off
Jun 5, 2024
timur27
force-pushed
the
fix/fallback-to-cc-when-hiding-pm
branch
from
June 5, 2024 20:37
7bc5a95
to
88dc8ef
Compare
timur27
changed the title
Fall back to credit card as default payment method when a payment method is toggled off
Fall back to credit card when a payment method is toggled off
Jun 5, 2024
timur27
requested review from
a team,
mdmoore and
FangedParakeet
and removed request for
a team and
mdmoore
June 5, 2024 20:56
FangedParakeet
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one: working as expected and code LGTM. 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8566
Changes proposed in this Pull Request
This PR adds the fallback to credit card payment method on the shortcode checkout page to make sure that a new payment method is selected after the currently selected payment method is toggled off because of country location restrictions.
Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge