Reporting: Add preset date selector to the Payment activity widget #8927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagpai
changed the title
6 tasks
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +917 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
This comment was marked as resolved.
This comment was marked as resolved.
nagpai
added
pr: in progress
pr: needs author reply
and removed
pr: needs review
pr: in progress
labels
This comment was marked as resolved.
This comment was marked as resolved.
Thanks for clarifying, that makes sense @jessy-p ! That's great info to put in the issue: |
Jinksi
reviewed
Jun 12, 2024
Jinksi
reviewed
Jun 12, 2024
Jinksi
reviewed
Jun 12, 2024
Jinksi
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
This tests well! 🙌 🌟
I've tested with a long-standing single-currency store as well as a multi-currency store locally.
The date preset options are correctly adhering to different account creation dates. The values rendered are correct as per the subsequent "View report" screen summaries.
I have some thoughts for code improvement as mentioned as comments, but none are blocking merge. I'm excited about getting this in the hands of our merchants. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8734
Changes proposed in this Pull Request
Not included in this PR
wcpaySettings.accountStatusappears to be a good contender - Reporting: AddAll timedate selector option for the payment activity widget #8929Last 7 days: June 3 - June 9, 2024#8928 - The Inline select item used requires a change in the button label format to make it match with the design.Testing instructions
_wcpay_feature_payment_overview_widgetis enabledPayment > Overviewand see that the date selector renders in the top right corner with default option ofLast 7 daysAdditional
InlineLabelSelectcomponent. 🙌 - @Jinksi .npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge