-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH Actions - Update direct usage of GitHub context in workflows + Update Code owners #8995
GH Actions - Update direct usage of GitHub context in workflows + Update Code owners #8995
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @achyuthajoy!
Added a minor comment and also will start a discussion on a private channel to avoid exposing security details in public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @achyuthajoy!
LGTM and the changes tested well 👍
Fixes https://github.com/Automattic/woocommerce-payments-server/issues/5442
Changes proposed in this Pull Request
github.actor
with$GITHUB_ACTOR
environment variable provided by GitHubgithub.run_id
with$GITHUB_RUN_ID
environment variable provided by GitHubTesting instructions
NA
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge