Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions - Update direct usage of GitHub context in workflows + Update Code owners #8995

Merged
merged 6 commits into from
Jun 24, 2024
Merged

GH Actions - Update direct usage of GitHub context in workflows + Update Code owners #8995

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e424814
Replace github.actor context with env variable
achyuthajoy Jun 21, 2024
6c76f59
Replace github.run_id with env var
achyuthajoy Jun 21, 2024
5e78c88
Update codeowners for GitHub workflows
achyuthajoy Jun 21, 2024
69a8c74
Add changelog
achyuthajoy Jun 21, 2024
1b54070
Merge branch 'develop' into gh-actions/fix-script-injection-vulnerabi…
achyuthajoy Jun 21, 2024
0bfc705
Update comment
achyuthajoy Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
# Each line is a file pattern followed by one or more owners.

# Harmony owns any files in the .github directory at the root of the repository and any of its subdirectories.
achyuthajoy marked this conversation as resolved.
Show resolved Hide resolved
/.github/ @Automattic/harmony
/.github/ @Automattic/transact-architecture-devops
4 changes: 2 additions & 2 deletions .github/workflows/post-release-updates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ jobs:
NEXT_RELEASE_VERSION: ${{ steps.next-version.outputs.NEXT_RELEASE_VERSION }}
run: |
cd wiki
git config user.name "${{ github.actor }}"
git config user.email "${{ github.actor }}@users.noreply.github.com"
git config user.name "$GITHUB_ACTOR"
git config user.email "$GITHUB_ACTOR@users.noreply.github.com"

HAS_CHANGES=false

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-code-freeze.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ jobs:
"type": "section",
"text": {
"type": "mrkdwn",
"text": "• Created a release branch `release/${{ env.RELEASE_VERSION }}` \n • Raised a <https://github.com/Automattic/woocommerce-payments/pull/${{ env.RELEASE_PR_ID }}|Pull Request> to `trunk`\n • Built a <https://github.com/Automattic/woocommerce-payments/actions/runs/${{ github.run_id }}|zip file and ran smoke tests> against it"
"text": "• Created a release branch `release/${{ env.RELEASE_VERSION }}` \n • Raised a <https://github.com/Automattic/woocommerce-payments/pull/${{ env.RELEASE_PR_ID }}|Pull Request> to `trunk`\n • Built a <https://github.com/Automattic/woocommerce-payments/actions/runs/$GITHUB_RUN_ID|zip file and ran smoke tests> against it"
}
},
{
Expand Down
5 changes: 5 additions & 0 deletions changelog/gh-actions-fix-script-injection-vulnerabilities
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Significance: patch
Type: dev
Comment: Update direct usage of GitHub contexts on workflows


Loading