Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with adding QIT authentication if password has spaces. #9751

Closed
wants to merge 11 commits into from
Closed

Fixes issue with adding QIT authentication if password has spaces. #9751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c888f35
Fixes issue with adding QIT authentication if password has spaces.
dmallory42 Nov 18, 2024
c5bf98a
Merge branch 'develop' into dev/fix-qit-spacing-error
dmallory42 Nov 18, 2024
f7cafe7
Reversing change inadvertandly made.
dmallory42 Nov 18, 2024
cdf2dcb
Merge branch 'dev/fix-qit-spacing-error' of github.com:Automattic/woo…
dmallory42 Nov 18, 2024
97ad248
Reversing change inadvertandly made.
dmallory42 Nov 18, 2024
055f34e
Reversing change inadvertandly made.
dmallory42 Nov 18, 2024
5cf1951
Reversing change inadvertandly made.
dmallory42 Nov 18, 2024
4e2ef83
Add changelog.
dmallory42 Nov 18, 2024
3e13384
Add changelog.
dmallory42 Nov 19, 2024
1f5b108
Matching with develop
dmallory42 Nov 19, 2024
87e1c50
Matching with develop
dmallory42 Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 3 additions & 85 deletions assets/css/admin.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,102 +155,20 @@
padding-top: 2px;
}

/* WCPay Fraud Risk Level meta box */
.wcpay-fraud-risk-level {
border-bottom: 1px solid #ddd;
padding: 8px 12px;
}

.wcpay-fraud-risk-level > p {
margin: 0;
}

.wcpay-fraud-risk-level__title {
font-weight: 600;
}

.wcpay-fraud-risk-level__bar {
display: grid;
gap: 4px;
grid-template-columns: 50% auto;
margin: 6px 0 8px;
}

.wcpay-fraud-risk-level__bar::after,
.wcpay-fraud-risk-level__bar::before {
background-color: #bbb;
content: '';
border-radius: 4px;
height: 4px;
}

.wcpay-fraud-risk-level--normal .wcpay-fraud-risk-level__title {
color: #008a20;
}

.wcpay-fraud-risk-level--normal .wcpay-fraud-risk-level__bar {
grid-template-columns: 15% auto;
}

.wcpay-fraud-risk-level--normal .wcpay-fraud-risk-level__bar::before {
background-color: #008a20;
}

.wcpay-fraud-risk-level--elevated .wcpay-fraud-risk-level__title {
color: #b16202;
}

.wcpay-fraud-risk-level--elevated .wcpay-fraud-risk-level__bar {
grid-template-columns: 60% auto;
}

.wcpay-fraud-risk-level--elevated .wcpay-fraud-risk-level__bar::before {
background-color: #b16202;
}

.wcpay-fraud-risk-level--highest .wcpay-fraud-risk-level__bar::before {
background-color: #b32d2e;
}

.wcpay-fraud-risk-level--highest .wcpay-fraud-risk-level__bar {
grid-template-columns: 100% auto;
}

.wcpay-fraud-risk-level--highest .wcpay-fraud-risk-level__bar::before {
background-color: #b32d2e;
}

/* WCPay Fraud Risk Action meta box */
#wcpay-order-fraud-and-risk-meta-box div.inside {
margin-top: 0;
padding: 0;
}

.wcpay-fraud-risk-action {
padding: 8px 12px 12px;
}

.wcpay-fraud-risk-action > p {
margin: 0 0 6px;
}

.wcpay-fraud-risk-action > p:last-child {
margin-bottom: 0;
}

.wcpay-fraud-risk-meta-allow,
.wcpay-fraud-risk-meta-review,
.wcpay-fraud-risk-meta-blocked {
font-weight: 600;
font-size: 14px;
}

.wcpay-fraud-risk-meta-allow img {
margin: 0 5px 0 0;
margin: 0 0 0 5px;
}

.wcpay-fraud-risk-meta-review img,
.wcpay-fraud-risk-meta-blocked img {
margin: 0 3px -3px 0;
margin: 0 0 -3px 3px;
}

.wcpay-fraud-risk-meta-allow {
Expand Down
84 changes: 83 additions & 1 deletion assets/css/admin.rtl.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,93 @@
padding-top: 2px;
}

/* WCPay Fraud Risk Level meta box */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmallory42 I wonder if these changed would be better to ship separately? they seem not related to the PR and there are no instructions where to test these design changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea where these changes came from. 😅 Will try and remove them from the PR!

.wcpay-fraud-risk-level {
border-bottom: 1px solid #ddd;
padding: 8px 12px;
}

.wcpay-fraud-risk-level > p {
margin: 0;
}

.wcpay-fraud-risk-level__title {
font-weight: 600;
}

.wcpay-fraud-risk-level__bar {
display: grid;
gap: 4px;
grid-template-columns: 50% auto;
margin: 6px 0 8px;
}

.wcpay-fraud-risk-level__bar::after,
.wcpay-fraud-risk-level__bar::before {
background-color: #bbb;
content: '';
border-radius: 4px;
height: 4px;
}

.wcpay-fraud-risk-level--normal .wcpay-fraud-risk-level__title {
color: #008a20;
}

.wcpay-fraud-risk-level--normal .wcpay-fraud-risk-level__bar {
grid-template-columns: 15% auto;
}

.wcpay-fraud-risk-level--normal .wcpay-fraud-risk-level__bar::before {
background-color: #008a20;
}

.wcpay-fraud-risk-level--elevated .wcpay-fraud-risk-level__title {
color: #b16202;
}

.wcpay-fraud-risk-level--elevated .wcpay-fraud-risk-level__bar {
grid-template-columns: 60% auto;
}

.wcpay-fraud-risk-level--elevated .wcpay-fraud-risk-level__bar::before {
background-color: #b16202;
}

.wcpay-fraud-risk-level--highest .wcpay-fraud-risk-level__bar::before {
background-color: #b32d2e;
}

.wcpay-fraud-risk-level--highest .wcpay-fraud-risk-level__bar {
grid-template-columns: 100% auto;
}

.wcpay-fraud-risk-level--highest .wcpay-fraud-risk-level__bar::before {
background-color: #b32d2e;
}

/* WCPay Fraud Risk Action meta box */
#wcpay-order-fraud-and-risk-meta-box div.inside {
margin-top: 0;
padding: 0;
}

.wcpay-fraud-risk-action {
padding: 8px 12px 12px;
}

.wcpay-fraud-risk-action > p {
margin: 0 0 6px;
}

.wcpay-fraud-risk-action > p:last-child {
margin-bottom: 0;
}

.wcpay-fraud-risk-meta-allow,
.wcpay-fraud-risk-meta-review,
.wcpay-fraud-risk-meta-blocked {
font-weight: 600;
font-size: 14px;
}

.wcpay-fraud-risk-meta-allow img {
Expand Down
4 changes: 4 additions & 0 deletions changelog/dev-fix-qit-spacing-error
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: dev

Fixing issue with parsing QIT authentication.
2 changes: 1 addition & 1 deletion tests/qit/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ QIT_BINARY=${QIT_BINARY:-./vendor/bin/qit}
# Add the partner by validating credentials.
if ! $QIT_BINARY list | grep -q 'partner:remove'; then
echo "Adding partner with QIT credentials..."
$QIT_BINARY partner:add --user=$QIT_USER --application_password=$QIT_PASSWORD
$QIT_BINARY partner:add --user=$QIT_USER --application_password="$QIT_PASSWORD"
if [ $? -ne 0 ]; then
echo "Failed to add partner. Exiting with status 1."
exit 1
Expand Down
Loading