Fixes issue with adding QIT authentication if password has spaces. #9751
+91
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commerce-payments into dev/fix-qit-spacing-error
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -542 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
oaratovskyi
reviewed
Nov 19, 2024
| @@ -155,11 +155,93 @@ | |||
| padding-top: 2px; | |||
| } | |||
|
|
|||
| /* WCPay Fraud Risk Level meta box */ | |||
There was a problem hiding this comment.
@dmallory42 I wonder if these changed would be better to ship separately? they seem not related to the PR and there are no instructions where to test these design changes
There was a problem hiding this comment.
I have no idea where these changes came from. 😅 Will try and remove them from the PR!
|
@oaratovskyi I had trouble getting this PR to play nicely so I just opened a new one: #9755 Closing this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9750
Changes proposed in this Pull Request
Prerequisites
Please read the P2 post linked for context on QIT and create the
local.envfile as specified in the instructions.Testing instructions
develop, use a password with a space in it in thelocal.envfile for theQIT_PASSWORDvariable (it doesn't need to be the correct password to see this error).npm run test:qit-securityNo arguments expected for "partner:add" command, got "<password>".See: PaJDYF-6n7-p2
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge