Fixes issue with QIT authentication parsing #9755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
|
@dmallory42 following the guide to set up QIT, I noticed there are In my case, the QIT thing works because it looks like this: so, we may not need this improvement, WDYT? |
|
Hi @oaratovskyi, sorry - only now seeing this comment!
We still need it, even if you use |
oaratovskyi
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9750
Changes proposed in this Pull Request
Prerequisites
Please read the P2 post linked for context on QIT and create the
local.envfile as specified in the instructions.Testing instructions
develop, use a password with a space in it in thelocal.envfile for theQIT_PASSWORDvariable (it doesn't need to be the correct password to see this error).npm run test:qit-securityNo arguments expected for "partner:add" command, got "<password>".See: PaJDYF-6n7-p2
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge