-
Notifications
You must be signed in to change notification settings - Fork 83
Add: Shared Inbox setting #1553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: patch | ||
| Type: changed | ||
|
|
||
| Add option to enable/disable the "shared inbox" to the "Advanced Settings". |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -187,6 +187,16 @@ public static function register_settings() { | |
| ) | ||
| ); | ||
|
|
||
| \register_setting( | ||
| 'activitypub_advanced', | ||
| 'activitypub_shared_inbox', | ||
| array( | ||
| 'type' => 'boolean', | ||
| 'description' => \__( 'Enable the shared inbox.', 'activitypub' ), | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do these need to be translated? Where are these stings visible?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. all settings are translated, that's why AI wanted to keep consistency. I am fine with both, but we should change the rest too then. |
||
| 'default' => false, | ||
| ) | ||
| ); | ||
|
|
||
| \register_setting( | ||
| 'activitypub', | ||
| 'activitypub_relays', | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "fourth" callback! :)
Should we create a separate class for these?