-
Notifications
You must be signed in to change notification settings - Fork 83
Add: Shared Inbox setting #1553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| \add_action( 'added_post_meta', array( self::class, 'updated_postmeta' ), 10, 4 ); | ||
| \add_filter( 'pre_option_activitypub_actor_mode', array( self::class, 'pre_option_activitypub_actor_mode' ) ); | ||
| \add_filter( 'pre_option_activitypub_authorized_fetch', array( self::class, 'pre_option_activitypub_authorized_fetch' ) ); | ||
| \add_filter( 'pre_option_activitypub_shared_inbox', array( self::class, 'pre_option_activitypub_shared_inbox' ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "fourth" callback! :)
Should we create a separate class for these?
| 'activitypub_shared_inbox', | ||
| array( | ||
| 'type' => 'boolean', | ||
| 'description' => \__( 'Enable the shared inbox.', 'activitypub' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these need to be translated? Where are these stings visible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all settings are translated, that's why AI wanted to keep consistency. I am fine with both, but we should change the rest too then.
* tag '5.7.0': (29 commits) Release 5.7.0 (Automattic#1574) Fix: Show error if site uses "Almost Pretty Permalink" structure (Automattic#1570) Admin: Add padding to extra fields nav links (Automattic#1569) Signature: Add compat for more key encodings (Automattic#1557) Reply block: Improve fallback embed (Automattic#1560) Add label for "Health Check" and "REST API" (Automattic#1571) change changelog items (Automattic#1572) Transformers: Allow setting properties to false. (Automattic#1567) Upgrades: Delete orphaned extra fields (Automattic#1566) Fix: Missing Actor in Outbox-Activities (Automattic#1564) Outbox: Properly handle username requests (Automattic#1559) Import: Load on admin_init (Automattic#1561) Move: support same-server domain migrations (Automattic#1530) Follow Me: add a button-only mode (Automattic#1133) Tests: Convert timestamp to int for comparison (Automattic#1556) Reply: Make Mastodon embeds work (Automattic#1555) Add: `Vary` header settings (Automattic#1552) Actors: Don't convert non-numeric strings to Blog user id (Automattic#1554) Add: Shared Inbox setting (Automattic#1553) Add: New Health checks (Automattic#1524) ...
Allow users to easily enable/disable the shared inbox feature without having to add constants.
Proposed changes:
Other information:
Testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Add option to enable/disable the "shared inbox" to the "Advanced Settings".