Skip to content

Conversation

@pfefferle
Copy link
Member

Allow users to easily enable/disable the vary header without having to add constants.

/cc @snarfed

Proposed changes:

  • Add option to enable/disable the Vary header for the Accept content negotiation feature of ActivityPub through the "Advanced Settings".

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to "Advanced Settings"
  • Enable Vary Header
  • Check output

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

Add option to enable/disable the Vary Header to the "Advanced Settings".

Allow users to easily enable/disable the vary header without having to add constants.

/cc @snarfed
@pfefferle pfefferle requested a review from obenland April 7, 2025 09:54
@pfefferle pfefferle self-assigned this Apr 7, 2025
@pfefferle pfefferle requested review from Copilot and obenland April 8, 2025 08:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (8)
  • .github/changelog/1552-from-description: Language not supported
  • activitypub.php: Language not supported
  • includes/class-activitypub.php: Language not supported
  • includes/class-options.php: Language not supported
  • includes/constants.php: Language not supported
  • includes/wp-admin/class-advanced-settings-fields.php: Language not supported
  • includes/wp-admin/class-health-check.php: Language not supported
  • includes/wp-admin/class-settings.php: Language not supported

@pfefferle pfefferle merged commit 1e396a7 into trunk Apr 8, 2025
11 checks passed
@pfefferle pfefferle deleted the add/vary-header-settings branch April 8, 2025 13:09
pfefferle added a commit that referenced this pull request Apr 10, 2025
* Add: `Vary` header settings

Allow users to easily enable/disable the vary header without having to add constants.

/cc @snarfed

* Add changelog

* add some slashes

* fix phpcs

* fix phpcs

* create options class

* load action class and re-order inits

* add some slashes

* Add phpdoc

* ensure to run migration as early as possible

* optimize wording

props @obenland

---------

Co-authored-by: Automattic Bot <sysops+ghmatticbot@automattic.com>
Co-authored-by: Konstantin Obenland <obenland@gmx.de>
jsit added a commit to jsit/wordpress-activitypub that referenced this pull request Nov 1, 2025
* tag '5.7.0': (29 commits)
  Release 5.7.0 (Automattic#1574)
  Fix: Show error if site uses "Almost Pretty Permalink" structure (Automattic#1570)
  Admin: Add padding to extra fields nav links (Automattic#1569)
  Signature: Add compat for more key encodings (Automattic#1557)
  Reply block: Improve fallback embed (Automattic#1560)
  Add label for "Health Check" and "REST API" (Automattic#1571)
  change changelog items (Automattic#1572)
  Transformers: Allow setting properties to false. (Automattic#1567)
  Upgrades: Delete orphaned extra fields (Automattic#1566)
  Fix: Missing Actor in Outbox-Activities (Automattic#1564)
  Outbox: Properly handle username requests (Automattic#1559)
  Import: Load on admin_init (Automattic#1561)
  Move: support same-server domain migrations (Automattic#1530)
  Follow Me: add a button-only mode (Automattic#1133)
  Tests: Convert timestamp to int for comparison (Automattic#1556)
  Reply: Make Mastodon embeds work (Automattic#1555)
  Add: `Vary` header settings (Automattic#1552)
  Actors: Don't convert non-numeric strings to Blog user id (Automattic#1554)
  Add: Shared Inbox setting (Automattic#1553)
  Add: New Health checks (Automattic#1524)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants