Skip to content

Conversation

@pfefferle
Copy link
Member

@pfefferle pfefferle commented Mar 31, 2025

To improve the onboarding experience!

Check if pretty permalinks are enabled and recommend to use threaded comments.

Proposed changes:

  • Added check for pretty permalinks
  • Added recommendation threaded comments

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Disable threaded comments and pretty permalinks
  • Go to site-health site
  • You should see an error and a recommendation

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

Check if pretty permalinks are enabled and recommend to use threaded comments.

To improve the onboarding experience!
@pfefferle pfefferle requested a review from obenland April 3, 2025 08:12
@pfefferle pfefferle self-assigned this Apr 3, 2025
@pfefferle pfefferle marked this pull request as ready for review April 3, 2025 08:12
pfefferle and others added 3 commits April 4, 2025 10:42
Co-authored-by: Konstantin Obenland <obenland@gmx.de>
Co-authored-by: Konstantin Obenland <obenland@gmx.de>
Copy link
Member

@obenland obenland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do all these translation strings get escaped by the health check page?

pfefferle and others added 2 commits April 4, 2025 14:55
Co-authored-by: Konstantin Obenland <obenland@gmx.de>
Co-authored-by: Konstantin Obenland <obenland@gmx.de>
@pfefferle pfefferle requested a review from obenland April 4, 2025 12:56
@obenland obenland merged commit e7bb8fd into trunk Apr 4, 2025
11 checks passed
@obenland obenland deleted the add/site-health-additions branch April 4, 2025 18:08
jsit added a commit to jsit/wordpress-activitypub that referenced this pull request Nov 1, 2025
* tag '5.7.0': (29 commits)
  Release 5.7.0 (Automattic#1574)
  Fix: Show error if site uses "Almost Pretty Permalink" structure (Automattic#1570)
  Admin: Add padding to extra fields nav links (Automattic#1569)
  Signature: Add compat for more key encodings (Automattic#1557)
  Reply block: Improve fallback embed (Automattic#1560)
  Add label for "Health Check" and "REST API" (Automattic#1571)
  change changelog items (Automattic#1572)
  Transformers: Allow setting properties to false. (Automattic#1567)
  Upgrades: Delete orphaned extra fields (Automattic#1566)
  Fix: Missing Actor in Outbox-Activities (Automattic#1564)
  Outbox: Properly handle username requests (Automattic#1559)
  Import: Load on admin_init (Automattic#1561)
  Move: support same-server domain migrations (Automattic#1530)
  Follow Me: add a button-only mode (Automattic#1133)
  Tests: Convert timestamp to int for comparison (Automattic#1556)
  Reply: Make Mastodon embeds work (Automattic#1555)
  Add: `Vary` header settings (Automattic#1552)
  Actors: Don't convert non-numeric strings to Blog user id (Automattic#1554)
  Add: Shared Inbox setting (Automattic#1553)
  Add: New Health checks (Automattic#1524)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants