Skip to content

Reply block: Improve fallback embed #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 11, 2025
Merged

Reply block: Improve fallback embed #1560

merged 4 commits into from
Apr 11, 2025

Conversation

@obenland
Copy link
Member

@obenland obenland commented Apr 9, 2025

Proposed changes:

  • Removes top and bottom margins when displaying in the Editor so it doesn't overflow the iframe.
  • Only shows repost and like count if they're passed in the ActivityPub object.
  • Accounts for Image attachments for compatibility with Pixelfed.

Before

Screenshot 2025-04-09 at 3 06 12 PM

After

Screenshot 2025-04-09 at 3 05 53 PM

Testing instructions:

  • Go to the Editor and insert a Federated Reply block.
  • Paste a URL for a Pixelfed post and make sure it displays correctly.

@obenland obenland added the Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. label Apr 9, 2025
@obenland obenland requested a review from a team April 9, 2025 20:08
@obenland obenland self-assigned this Apr 9, 2025
pfefferle
pfefferle approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@pfefferle pfefferle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with misskey and pixelfed, works like a charm!

@obenland obenland merged commit 166e54b into trunk Apr 11, 2025
11 checks passed
@obenland obenland deleted the update/fallback-embed branch April 11, 2025 12:57
jsit added a commit to jsit/wordpress-activitypub that referenced this pull request Nov 1, 2025
@jsit
Merge tag '5.7.0' into fix/nicename
fd1508e 
* tag '5.7.0': (29 commits)
  Release 5.7.0 (Automattic#1574)
  Fix: Show error if site uses "Almost Pretty Permalink" structure (Automattic#1570)
  Admin: Add padding to extra fields nav links (Automattic#1569)
  Signature: Add compat for more key encodings (Automattic#1557)
  Reply block: Improve fallback embed (Automattic#1560)
  Add label for "Health Check" and "REST API" (Automattic#1571)
  change changelog items (Automattic#1572)
  Transformers: Allow setting properties to false. (Automattic#1567)
  Upgrades: Delete orphaned extra fields (Automattic#1566)
  Fix: Missing Actor in Outbox-Activities (Automattic#1564)
  Outbox: Properly handle username requests (Automattic#1559)
  Import: Load on admin_init (Automattic#1561)
  Move: support same-server domain migrations (Automattic#1530)
  Follow Me: add a button-only mode (Automattic#1133)
  Tests: Convert timestamp to int for comparison (Automattic#1556)
  Reply: Make Mastodon embeds work (Automattic#1555)
  Add: `Vary` header settings (Automattic#1552)
  Actors: Don't convert non-numeric strings to Blog user id (Automattic#1554)
  Add: Shared Inbox setting (Automattic#1553)
  Add: New Health checks (Automattic#1524)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pfefferle pfefferle pfefferle approved these changes

Assignees

@obenland obenland

Labels

Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@obenland @pfefferle