Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist: Add 'pending' State to steps #25935

Closed
ockham opened this issue Jul 9, 2018 · 1 comment
Closed

Checklist: Add 'pending' State to steps #25935

ockham opened this issue Jul 9, 2018 · 1 comment

Comments

@ockham
Copy link
Contributor

ockham commented Jul 9, 2018

To reflect e.g. ongoing VaultPress or Akismet installation/setup/provisioning.

Draw inspiration from https://github.com/Automattic/wp-calypso/blob/master/client/my-sites/checkout/checkout-thank-you/jetpack-thank-you-card.jsx.

Fortunately, we only need a less fine-grained approach (i.e. we don't need feature granularity -- plugin granularity should be enough, e.g. VaultPress corresponds to the 'Backups and Scanning' step, Akismet to 'Spam Protection'). Should be enough to select plugins = getPluginsForSite( state, siteId, false ) in connect(), and do something like

const pluginsStatus = reduce(
plugins,
( completed, plugin ) => {
if ( 'done' === plugin.status ) {
completed[ plugin.slug ] = 'done';
} else if ( plugin.hasOwnProperty( 'error' ) && plugin.error ) {
completed[ plugin.slug ] = 'error';
} else {
completed[ plugin.slug ] = 'wait';
}
return completed;
},
{}
);

@tyxla
Copy link
Member

tyxla commented Apr 17, 2019

This can now be closed - we're doing it in a different way than what's suggested here though. Installation, activation and configuration now happens on the server side, and the following PRs were responsible for making the "pending" state be displayed on the client.

#31684
#31547
#32152
#31963

@tyxla tyxla closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants