Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Add in-progress state to checklist tasks #31963

Merged
merged 3 commits into from
Apr 3, 2019

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Apr 2, 2019

Changes proposed in this Pull Request

  • Introduce an in-progress state to checklist tasks.

Background

We need this for the Jetpack checklist project, see p5XAZ9-2c7-p2 for more details.

Preview

Testing instructions

  • Checkout this branch and build Calypso.
  • Go to http://calypso.localhost:3000/devdocs/design/checklist
  • Verify the new third task looks and works well.
  • Verify the existing 2 tasks still look and work well, too.
  • Test the checklist in an existing site, and verify it still works well and unchanged.

@tyxla tyxla added Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR NUX Components Checklist [Type] Feature progress labels Apr 2, 2019
@tyxla tyxla self-assigned this Apr 2, 2019
@matticbot
Copy link
Contributor

@tyxla tyxla requested review from a team April 2, 2019 15:04
Copy link
Member

@jeffgolenski jeffgolenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking tremendous @tyxla - Only a small change request. Can we change "Your setup list" to "Your Jetpack setup progress" above the progress indicator? This way folks know it's not just a random list, but a progress list for Jetpack.

EDIT: The above comment is actually not related to this PR. My Mistake. Ignore it for this merge.

@jeffgolenski jeffgolenski removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Apr 2, 2019
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked out the demo and gave the checklist a spin just in case LGTM

@tyxla
Copy link
Member Author

tyxla commented Apr 3, 2019

Thanks, folks!

@tyxla tyxla merged commit f57438a into master Apr 3, 2019
@tyxla tyxla deleted the update/checklist-task-in-progress-state branch April 3, 2019 09:56
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 3, 2019
@tyxla
Copy link
Member Author

tyxla commented Apr 3, 2019

Can we change "Your setup list" to "Your Jetpack setup progress" above the progress indicator? This way folks know it's not just a random list, but a progress list for Jetpack.

@jeffgolenski I'm going to follow up in another PR with this.

@tyxla
Copy link
Member Author

tyxla commented Apr 3, 2019

@jeffgolenski done in #31990.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants