Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Checklist: Update progress text #31990

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Jetpack Checklist: Update progress text #31990

merged 2 commits into from
Apr 3, 2019

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Apr 3, 2019

Changes proposed in this Pull Request

Preview

Before:

After:

Testing instructions

@tyxla tyxla added Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR NUX Components Checklist [Type] Feature progress labels Apr 3, 2019
@tyxla tyxla self-assigned this Apr 3, 2019
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/jetpack-checklist-header-progress-text

@tyxla tyxla requested review from a team April 3, 2019 10:21
@tyxla tyxla mentioned this pull request Apr 3, 2019
Merged
sirreal
sirreal approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested and working as expected 👍

@sirreal sirreal removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 3, 2019
jeffgolenski
jeffgolenski approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@jeffgolenski jeffgolenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIPPPPPPP

@tyxla tyxla added [Status] Ready to Merge and removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Apr 3, 2019
@tyxla tyxla merged commit f7bb79f into master Apr 3, 2019
@tyxla tyxla deleted the update/jetpack-checklist-header-progress-text branch April 3, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirreal sirreal sirreal approved these changes

@jeffgolenski jeffgolenski jeffgolenski approved these changes

Assignees

@tyxla tyxla

Labels
Checklist Components Jetpack NUX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tyxla @matticbot @jeffgolenski @sirreal