-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checklists: Clean up and organize #26554
Conversation
cbc9ee0
to
3eb2cf6
Compare
0f8ee3d
to
8d3dca6
Compare
8d3dca6
to
e40788f
Compare
Marked as in progress. I'll remove the |
Cancel that. It will be much simpler to land both, then work more on component organization that will allow that particular util to be removed. Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing well, code looks good. Nice cleanup 👍 🚢
Description
This is a set of changes to make some Checklist components easier to work with and simpler to reason about.
ChecklistShowShare
connect
torecordTracksEvent
internally rather than expect to receive as passed prop. Updated where used.ChecklistMain
Reduce indirection by replacing render methods that contain low-complexity conditional logic with inline JSX.
Sort imports.
Simplify
connect
.Replace
find
that checks whether some element of an array is true for a predicate with canonicalsome
.Testing
No functional changes. Verify that:
/checklist
or/stats
). Look forcalypso_checklist_completed_site_share
events./checklist
continue to render and behave as in production.