Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guided Tours: Add Jetpack Backups Rewind tour to config #32274

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Guided Tours: Add Jetpack Backups Rewind tour to config #32274

merged 1 commit into from
Apr 16, 2019

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Apr 15, 2019

Changes proposed in this Pull Request

Testing instructions

@tyxla tyxla added Jetpack [Pri] Normal Schedule for the next available opportuinity. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. NUX Guided Tours [Type] Feature progress labels Apr 15, 2019
@tyxla tyxla requested review from sgomes and a team April 15, 2019 11:27
@tyxla tyxla requested a review from a team as a code owner April 15, 2019 11:27
@tyxla tyxla self-assigned this Apr 15, 2019
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/guided-tours-jetpack-backups-rewind

@tyxla tyxla mentioned this pull request Apr 15, 2019
Merged
sgomes
sgomes reviewed Apr 15, 2019
View reviewed changes
Copy link
Contributor

@sgomes sgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise, LGTM! 👍

I'll leave it to the Guided Tours experts to confirm the guided tour still works correctly after this change 🙂

@ockham
Copy link
Contributor

ockham commented Apr 16, 2019

Testing instructions

That's a long list of instructions there 😅 Is it sufficient to go through the shorter list at #32271?

@tyxla
Copy link
Member Author

tyxla commented Apr 16, 2019

@ockham yeah, that should be sufficient 😉 👍

ockham
ockham approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JP Rewind Guided Tour still works 👍

@tyxla tyxla merged commit fd691c8 into master Apr 16, 2019
@tyxla tyxla deleted the add/guided-tours-jetpack-backups-rewind branch April 16, 2019 14:07
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgomes sgomes sgomes left review comments

@ockham ockham ockham approved these changes

Assignees

@tyxla tyxla

Labels
Checklist Guided Tours Jetpack NUX [Pri] Normal Schedule for the next available opportuinity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tyxla @matticbot @ockham @sgomes