Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout: Make it possible to expose jQuery for paygate.js script #3456

Merged
merged 1 commit into from
Feb 23, 2016
Merged

Checkout: Make it possible to expose jQuery for paygate.js script #3456

merged 1 commit into from
Feb 23, 2016

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Feb 22, 2016

Fix for #3405.

It fixes the following issue:

When I click the Pay button after filling the credit card details, a blue notice saying "Submitting payment" appears but nothing happens. I've tried several times and users are not charged, and nothing happens even after waiting 3-5 minutes.

This is part of Desktop app change. It should be tested together with: Automattic/wp-desktop#93. More details there.

@gziolo gziolo added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] WordPress Desktop App Features and improvements related to the WordPress Desktop App. [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. labels Feb 22, 2016
@gziolo gziolo self-assigned this Feb 22, 2016
@gziolo gziolo added this to the Gold: backlog milestone Feb 22, 2016
@gziolo gziolo mentioned this pull request Feb 22, 2016
Merged
@scruffian
Copy link
Member

Good idea leaving a comment here 👍

@scruffian scruffian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 22, 2016
gziolo added a commit that referenced this pull request Feb 23, 2016
@gziolo
Merge pull request #3456 from Automattic/fix/3405-paygate-broken-dekstop
9bb2245 
Checkout: Make it possible to expose jQuery for paygate.js script
@gziolo gziolo merged commit 9bb2245 into master Feb 23, 2016
@gziolo gziolo deleted the fix/3405-paygate-broken-dekstop branch February 23, 2016 09:27
@gziolo gziolo mentioned this pull request Feb 23, 2016
Merged
@Tug Tug mentioned this pull request Feb 23, 2016
Merged
@gziolo gziolo restored the fix/3405-paygate-broken-dekstop branch February 23, 2016 14:56
@gziolo gziolo deleted the fix/3405-paygate-broken-dekstop branch February 23, 2016 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gziolo gziolo

Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com. [Feature] WordPress Desktop App Features and improvements related to the WordPress Desktop App. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
Absinthe: backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@gziolo @scruffian