Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout: Add missing jquery dependency for paygate.js #3497

Merged
merged 1 commit into from
Feb 23, 2016

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Feb 23, 2016

Fixes missing jQuery dependency introduced in #3456.

screen shot 2016-02-23 at 10 09 44

### Testing wp-calypso

It shouldn't show up anymore when executing make run in wp-calypso`.

Testing wp-desktop

  1. Checkout fix/3456-add-missing-jquery-dependency branch in calypso folder.
  2. Execute make run.
  3. Try to purchase any upgrade.
  4. Provide data for new credit card to finalise purchase and click purchase button.
  5. Purchase should complete.

@gziolo gziolo added the [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. label Feb 23, 2016
@gziolo gziolo self-assigned this Feb 23, 2016
@gziolo gziolo added this to the Gold: backlog milestone Feb 23, 2016
@gziolo gziolo added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 23, 2016
@Tug
Copy link
Contributor

Tug commented Feb 23, 2016

LGTM, the errors are gone 👍

@Tug Tug added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 23, 2016
gziolo added a commit that referenced this pull request Feb 23, 2016
…dependency

Checkout: Add missing jquery dependency for paygate.js
@gziolo gziolo merged commit 18cf64a into master Feb 23, 2016
@gziolo gziolo deleted the fix/3456-add-missing-jquery-dependency branch February 23, 2016 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants