Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purchases: Fix 'Edit Card Details' form failing while checking for input errors #3496

Merged
merged 1 commit into from
Feb 23, 2016
Merged

Purchases: Fix 'Edit Card Details' form failing while checking for input errors #3496

merged 1 commit into from
Feb 23, 2016

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Feb 23, 2016

This PR fixes a bug reported at p2MSmN-4vV-p2 :

Unable to update card info on the billing history page?
User tried updating their card info in Calypso and the Save button did nothing.

Testing Instructions

  • Checkout this branch and go to http://calypso.localhost:3000/purchases
  • Click on a purchase you made using a credit card (do one first if you have none)
  • Click on "Edit Payment Method"
  • Edit the form, it should not throw errors in the console
  • Validate the form, it should work as expected

Review

  • Product Review
  • Code Review

@Tug Tug added [Type] Bug [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Feb 23, 2016
@Tug Tug self-assigned this Feb 23, 2016
@Tug Tug added this to the Amber: Backlog milestone Feb 23, 2016
@Tug Tug added [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] In Progress labels Feb 23, 2016
@Tug
Copy link
Contributor Author

Tug commented Feb 23, 2016

Note: you may be affected by this bug while testing:
#3497

@Tug
Copy link
Contributor Author

Tug commented Feb 23, 2016

Rebased, the jQuery bug should be gone!

@Tug Tug mentioned this pull request Feb 23, 2016
Closed
@klimeryk
Copy link
Contributor

LGTM! 👍

/cc @umurkontaci - weird that this did not come up during your PR and mine code review :/

@klimeryk klimeryk added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 23, 2016
@fabianapsimoes
Copy link
Contributor

Product 👍

Thanks for the quick fix, Tug!

Tug added a commit that referenced this pull request Feb 23, 2016
@Tug
Merge pull request #3496 from Automattic/fix/edit-credit-card-form
b2c952a 
Purchases: Fix 'Edit Card Details' form failing while checking for input errors
@Tug Tug merged commit b2c952a into master Feb 23, 2016
@Tug Tug deleted the fix/edit-credit-card-form branch February 23, 2016 13:41
@fabianapsimoes fabianapsimoes modified the milestone: Amber: Backlog Mar 2, 2016
@awaisab172 awaisab172 mentioned this pull request Jun 24, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Feb 11, 2024
Open
@awaisab172 awaisab172 mentioned this pull request Mar 23, 2024
Open
@awaisab172 awaisab172 mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tug Tug

Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tug @klimeryk @fabianapsimoes