-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer: Upgrade deps for composer 2 #47498
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
I pushed a tiny readme change to the editing toolkit plugin. That way we can see if the CI tools which rely on this package work! If that passes, this looks great to me |
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D52895-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note: the phpunit failure is a separate issue |
Thanks for reviewing, Noah!
Shall we revert that change, or keep it? 😄 |
we can keep it, just a tiny grammar/style improvement 😁 |
e2f280a
to
41d77be
Compare
So this is safe to ignore, @noahtallen?
Noting that I have no intention of releasing Editing Toolkit for this markdown change, but this should be completely safe to release with other changes. |
Absolutely, I would not have expected you to :)
Yes, it would have been. I believe the issue has been fixed over the past several days, so after a rebase I would expect it to pass now. |
41d77be
to
baa9498
Compare
Rebased.
That was for posterity or someone handling a release, didn't intend to direct it at you 😆 |
Attempting to fix the tests: #47766 |
The phpunit tests are not a quick fix and are not introduced here. I'll merge. |
Phpunit tests fixed in #47979 |
Upgrade composer dependencies.
I have composer 2 installed, one of our composer packages is incompatible with it. Upgrade that composer package and upgrade our composer deps.
Previously, I was hitting issues with
yarn dev
fromapps/editing-toolkit-plugin
:I could not
composer install
becuase:Testing instructions
I'm not sure how many places use composer, but
yarn dev
underapps/editing-toolkit-plugin
should work after this change.