Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing Toolkit: pin wp-env version #47979

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Editing Toolkit: pin wp-env version #47979

merged 1 commit into from
Dec 2, 2020

Conversation

noahtallen
Copy link
Contributor

Fixes the phpunit tests by updating wp-env.

The previous entry for wp-env was *, which apparently resolves to a really old wp-env version. A version which didn't include phpunit support yet.

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/wp-env-version

@noahtallen noahtallen self-assigned this Dec 2, 2020
@noahtallen noahtallen added the Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin label Dec 2, 2020
@noahtallen noahtallen requested a review from sirreal December 2, 2020 22:32
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 2, 2020
@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D53675-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

This was referenced Dec 2, 2020
Closed
Merged
Closed
andrewserong
andrewserong approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you were needing a review from Good Mountain, but here's an LGTM from me 😀

image

@noahtallen
Copy link
Contributor Author

Thanks! Always good to have a second eye on things just in case :)

@noahtallen noahtallen merged commit f1aa51a into trunk Dec 2, 2020
@noahtallen noahtallen deleted the update/wp-env-version branch December 2, 2020 23:06
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 2, 2020
@sirreal
Copy link
Member

sirreal commented Dec 3, 2020

Nice, thanks @noahtallen!

@ciampo ciampo mentioned this pull request Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewserong andrewserong andrewserong approved these changes

@sirreal sirreal Awaiting requested review from sirreal

Assignees

@noahtallen noahtallen

Labels
Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noahtallen @matticbot @sirreal @andrewserong