Goodbye, IE 11 #55142
Merged
Goodbye, IE 11 #55142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
|
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-12442 |
20 tasks
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
scinos
reviewed
Aug 4, 2021
noahtallen
force-pushed
the
enable-fallback-redirect-prod
branch
2 times, most recently
from
dcb9451 to
a3da43c
Compare
|
Reminder to myself to scan and remove any parts about IE11 in the |
noahtallen
force-pushed
the
enable-fallback-redirect-prod
branch
from
a3da43c to
04ffded
Compare
griffbrad
approved these changes
Aug 9, 2021
github-actions
bot
removed
the
[Status] Needs Review
flootr
added a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Enable redirect for fallback browsers in all environments. Follow-up from #53221, which implemented the redirect for development and some testing environments. I also took the opportunity to remove documentation referencing IE11 and the fallback build.
See #53222 for follow-up tasks.
Testing instructions
Use calypso.live for the following:
/browsehappy. Browserstack works well for a quick test. (Just load the calypso.live link in IE 11. You can also test the "continue anyways" path and ensure it does not redirect after that.We will have to double check this behavior after shipping once the deployment makes it to staging, and then again after it gets to prod, as this code change modifies environment configuration.