Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goodbye, IE 11 #55142

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Goodbye, IE 11 #55142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66930f0
Remove docs about fallback
noahtallen Aug 3, 2021
04ffded
Enable fallback redirect in all environments
noahtallen Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/production.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@
"use-translation-chunks": true,
"woocommerce/extension-referrers": false,
"wpcom-user-bootstrap": true,
"wordpress-action-search": false
"wordpress-action-search": false,
"redirect-fallback-browsers": true
},
"siftscience_key": "a4f69f6759",
"oauth_client_id": "39911",
Expand Down
3 changes: 2 additions & 1 deletion config/stage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@
"woocommerce/extension-referrers": false,
"woocommerce/store-on-non-atomic-sites": true,
"wpcom-user-bootstrap": true,
"wordpress-action-search": false
"wordpress-action-search": false,
"redirect-fallback-browsers": true
},
"siftscience_key": "e00e878351",
"oauth_client_id": "39911",
Expand Down
3 changes: 2 additions & 1 deletion config/test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
"upgrades/upcoming-renewals-notices": true,
"upgrades/wpcom-monthly-plans": true,
"wpcom-user-bootstrap": false,
"wordpress-action-search": false
"wordpress-action-search": false,
"redirect-fallback-browsers": true
}
}
4 changes: 0 additions & 4 deletions docs/development-workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ For example: `ENTRY_LIMIT=entry-login,entry-main yarn start` would start Calypso

To find all available entry points, you can refer to the `entry` option in Calypso's primary `webpack.config.js` file.

### Internet Explorer

It's possible to debug/fix IE issues using the [fallback development workflow](./fallback-development-workflow.md).

## Tests

If you want to run the tests for a specific library in `client/` use:
Expand Down
33 changes: 0 additions & 33 deletions docs/fallback-development-workflow.md
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion docs/merge-checklist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ This document aims to provide a list of things to check and test whenever you ar
It's also important to keep the general WP.com commit checklist at hand (modified for Calypso):

1. It must be responsive on phone, tablet, and desktop; interactions must be fluid on a touch device.
2. Test in IE11+, Chrome, Firefox, Mac/Win on the desktop.
2. Test in Chrome, Firefox, Mac/Win on the desktop.
3. Collect relevant and useful stats/events. What questions do they answer? How do you expect them to change over time?
4. All strings must be fully translatable (without concatenation, handling plurals), and you should be aware of how long strings affect layout.
5. Any visual assets involved must be HiDPI optimized and/or scalable.
Expand Down