-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sensor noise #118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
knorrrr
requested review from
taikitanaka3,
isamu-takagi and
yuasabe
and removed request for
taikitanaka3
September 26, 2024 10:39
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actuation_cmd_converter は元になるソースがあるのでその著作権表示を維持していますが、センサーのは新規なので2024でお願いします。
aichallenge/workspace/src/aichallenge_system/aichallenge_awsim_adapter/src/sensor_converter.cpp
Outdated
Show resolved
Hide resolved
aichallenge/workspace/src/aichallenge_system/aichallenge_awsim_adapter/src/sensor_converter.hpp
Outdated
Show resolved
Hide resolved
…_adapter/src/sensor_converter.cpp Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
…_adapter/src/sensor_converter.hpp Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
This reverts commit 1fd3a86.
isamu-takagi
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
実機に近しいセンサーノイズを付与しました。
またgnssに関してはdelayの実装も行いました。
付与対象:
/awsim/gnss/pose: geometry_msgs/msg/PoseStamped(遅延も実装)
/awsim/gnss/pose_with_covariance: geometry_msgs/msg/PoseWithCovarianceStamped(遅延も実装)
/awsim/imu: sensor_msgs/msg/Imu
/awsim/steering_status: autoware_auto_vehicle_msgs/msg/SteeringReport