Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OutputVersion nuke target #14890

Merged
merged 4 commits into from
Mar 9, 2024
Merged

Add OutputVersion nuke target #14890

merged 4 commits into from
Mar 9, 2024

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Mar 9, 2024

What does the pull request do?

Currently our GitHub version number bot outputs hardcoded version base (i.e. - 11.0.999 or 11.1.999 + BuildId env var), instead of using actual number. This PR is a first step to fix that.

It's based on nuke (again) just to keep version resolving in a single place, and not duplicate it in other scripts.

@maxkatz6 maxkatz6 changed the title Fix version output Add OutputVersion nuke target Mar 9, 2024
@maxkatz6 maxkatz6 merged commit 462e4d1 into master Mar 9, 2024
2 of 6 checks passed
@maxkatz6 maxkatz6 deleted the fix-version-output branch March 9, 2024 02:47
@maxkatz6 maxkatz6 added area-infrastructure Issues related to CI/tooling infrastructur backported-11.0.x backported-11.1.x labels Mar 9, 2024
maxkatz6 added a commit that referenced this pull request Mar 9, 2024
* Replace PRNumber with VersionNumber+nuke

* Restore prId file

* Fix env var name

* Change artifact name back for compatibility
maxkatz6 added a commit that referenced this pull request Mar 9, 2024
* Replace PRNumber with VersionNumber+nuke

* Restore prId file

* Fix env var name

* Change artifact name back for compatibility
# Conflicts:
#	azure-pipelines.yml
@grokys grokys added backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch and removed backported-11.0.x labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Issues related to CI/tooling infrastructur backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch backported-11.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants