Sys 3828 upgrade substrate version #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-cholakov
requested review from
vukomir,
RuiSMagalhaes,
nahuseyoum,
alexpArtos,
fluorostani and
thadouk
as code owners
Signed-off-by: Ivan Cholakov <icholakov1@gmail.com>
Signed-off-by: Ivan Cholakov <icholakov1@gmail.com> Co-authored-by: Nahu <39748285+nahuseyoum@users.noreply.github.com>
ivan-cholakov
force-pushed
the
SYS-3828-upgrade-substrate-version
branch
from
c8ecccc
to
36be878
Compare
thadouk
approved these changes
Feb 22, 2024
Comment on lines
+5736
to
+5738
| // Balances::set_lock(NOMINATOR_LOCK_ID, &account_id, 0, WithdrawReasons::all()); | ||
| // // Note that we tried to call `set_lock(0)` and it ignored it, we still have our lock | ||
| // assert_eq!(crate::mock::query_lock_amount(account_id, NOMINATOR_LOCK_ID), Some(1)); |
There was a problem hiding this comment.
this seems to be left commented out.
We are skipping a check/test this way
nahuseyoum
approved these changes
Feb 23, 2024
fluorostani
approved these changes
Feb 23, 2024
Co-authored-by: Thanos Doukoudakis <56822898+thadouk@users.noreply.github.com> Signed-off-by: Ivan Cholakov <icholakov1@gmail.com>
Co-authored-by: Thanos Doukoudakis <56822898+thadouk@users.noreply.github.com> Signed-off-by: Ivan Cholakov <icholakov1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Screencast.from.22-02-24.11.07.24.webm
Tested locally and on increment chain
Type of change/Merge
🚨What type of change is this PR?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR.