fix: fix various warnings in noir-protocol-circuits (#4048)

AztecProtocol · Jan 16, 2024 · 470d046 · 470d046
1 parent 3ce3ef7
commit 470d046
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 4 deletions.
diff --git a/barretenberg/cpp/_deps/benchmark-src b/barretenberg/cpp/_deps/benchmark-src
diff --git a/barretenberg/cpp/_deps/gtest-src b/barretenberg/cpp/_deps/gtest-src
diff --git a/yarn-project/noir-protocol-circuits/src/crates/rollup-lib/src/base/base_rollup_inputs.nr b/yarn-project/noir-protocol-circuits/src/crates/rollup-lib/src/base/base_rollup_inputs.nr
@@ -204,7 +204,7 @@ impl BaseRollupInputs {
         )
     }
 
-    fn create_nullifier_subtree<N>(self, leaves: [NullifierLeafPreimage; N]) -> Field {
+    fn create_nullifier_subtree<N>(leaves: [NullifierLeafPreimage; N]) -> Field {
         calculate_subtree(leaves.map(|leaf:NullifierLeafPreimage| leaf.hash()))
     }
 
@@ -359,7 +359,7 @@ impl BaseRollupInputs {
     }
 }
 
-fn verify_kernel_proof(proof: Proof) -> bool {
+fn verify_kernel_proof(_proof: Proof) -> bool {
     // TODO: Just return true as we are mocking out the proof verification
     // and aggregation.
     // TODO(Kev): It may make sense to move all of these methods into a 

diff --git a/yarn-project/noir-protocol-circuits/src/crates/rollup-lib/src/components.nr b/yarn-project/noir-protocol-circuits/src/crates/rollup-lib/src/components.nr
@@ -14,7 +14,7 @@ use dep::types::abis::append_only_tree_snapshot::AppendOnlyTreeSnapshot;
  */
 pub fn aggregate_proofs(
     left: BaseOrMergeRollupPublicInputs,
-    right: BaseOrMergeRollupPublicInputs
+    _right: BaseOrMergeRollupPublicInputs
 ) -> AggregationObject {
     // TODO: Similar to cpp code this does not do anything.
     left.aggregation_object

diff --git a/yarn-project/noir-protocol-circuits/src/crates/rollup-lib/src/merkle_tree.nr b/yarn-project/noir-protocol-circuits/src/crates/rollup-lib/src/merkle_tree.nr
@@ -4,7 +4,7 @@ struct MerkleTree<N> {
 }
 
 impl<N> MerkleTree<N> {
-    fn new(leaves: [Field; N]) -> Self {
+    pub fn new(leaves: [Field; N]) -> Self {
         let mut nodes = [0; N];
 
         // We need one less node than leaves, but we cannot have computed array lengths