fix: fix various warnings in noir-protocol-circuits

[TomAFrench]

We've got a large number of warnings being outputted. This PR addresses some of them.

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 4cdc0963 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	221,004	866,264	3,444,692
l1_rollup_execution_gas	934,148	3,968,738	24,788,228
l2_block_processing_time_in_ms	1,550 (+15%)	5,145	21,219
note_successful_decrypting_time_in_ms	312 (+1%)	934 (+1%)	3,420 (+1%)
note_trial_decrypting_time_in_ms	23.2 (+43%)	62.2 (+17%)	142 (+2%)
l2_block_building_time_in_ms	14,909 (-1%)	59,514	238,379
l2_block_rollup_simulation_time_in_ms	10,526	42,140 (+1%)	168,986
l2_block_public_tx_process_time_in_ms	4,348 (-2%)	17,295	69,124 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,945	28,672
note_history_successful_decrypting_time_in_ms	2,188 (-1%)	4,437
note_history_trial_decrypting_time_in_ms	115 (-7%)	184 (+3%)
node_database_size_in_bytes	3,621,674	3,731,381
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	214 (+1%)	44,681	25,561
private-kernel-ordering	166 (+1%)	43,753	14,809
base-rollup	1,068	128,338	881
root-rollup	80.0 (+1%)	4,088	677
private-kernel-inner	291	71,208	25,561
public-kernel-private-input	206	31,863	25,561
public-kernel-non-first-iteration	203	31,905	25,561
merge-rollup	7.61	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.2	16.4 (-5%)	13.7 (+1%)	19.0 (+2%)	23.6 (-1%)	65.1 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	88.7 (+4%)	50.0	243 (-1%)	467	914	3,571
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	128 (+7%)	59.7	359 (-1%)	731	1,414	5,585
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	64.5	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,455	32,219

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	384 (+3%)	1,088

Metric	1 public data writes
tx_sequencer_processing_time_ms	536