Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engineer can start the data archiver with RPC endpoint and rollup contract configuration #10

Closed
PhilWindle opened this issue Mar 2, 2023 · 2 comments
Closed

Engineer can start the data archiver with RPC endpoint and rollup contract configuration #10

PhilWindle opened this issue Mar 2, 2023 · 2 comments
Assignees
@benesjan

Comments

@PhilWindle
Copy link
Collaborator

It should be possible to start the data archiver with configuration for an Ethereum host, a rollup contract, a starting block and a persistence interface.
@PhilWindle PhilWindle added this to A3 Mar 2, 2023
@PhilWindle PhilWindle converted this from a draft issue Mar 2, 2023
@PhilWindle PhilWindle added this to the 📜 Deploy a Contract milestone Mar 7, 2023
@benesjan benesjan self-assigned this Mar 8, 2023
@benesjan benesjan moved this from Todo to In Progress in A3 Mar 8, 2023
@benesjan benesjan mentioned this issue Mar 8, 2023
Closed
6 tasks
@benesjan
Copy link
Contributor

@PhilWindle what do you mean by persistence interface?

@PhilWindle
Copy link
Collaborator Author

@benesjan I mean that the archiver should be written in a way that abstracts how the data is stored. So it should take an argument that is merely an interface to storing/retrieving whatever data is required. The concrete implementation of that interface could be a db or a filesystem or just a set of in memory data structures.

In fact, the other arguments I have specified are incorrect. It should take an interface that abstracts the ethereum host, rollup contract etc away.

@benesjan benesjan mentioned this issue Mar 13, 2023
Merged
6 tasks
@benesjan benesjan moved this from In Progress to Done in A3 Apr 3, 2023
ludamad pushed a commit that referenced this issue Jul 19, 2023
@critesjosh
Merge pull request #10 from asharma13524/patch-5
375c0dc 
Fix grammar error in accounts.md
ludamad pushed a commit that referenced this issue Jul 21, 2023
@critesjosh
Merge pull request #10 from asharma13524/patch-5
54dd85e 
Fix grammar error in accounts.md
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
rahul-kothari pushed a commit that referenced this issue Aug 15, 2024
@charlielye
fix: Docker.dockerignore file can be huge. (#8023)
cee9d9a 
We run into some nutty error when dockerignore files get large (circleci
path):

```
#3 [internal] load metadata for docker.io/library/ubuntu:noble
#3 sha256:afb7fa05fafd7c9e9fe1ecefd45ae0531e51b736cd519c2fb8893340e4e08b59
#3 DONE 0.4s

#10 [internal] load build context
#10 sha256:8189bdeed2ad9e316ae51d8dddc8d96a01e5180ee99f9f37015f7c3dc8de7e41
#10 ERROR: rpc error: code = Internal desc = header list size to send violates the maximum size (1048896 bytes) set by server
```

This became the case with avm-transpiler as it's build context is the
root of the monorepo so it can gain access to the noir source code. The
autogenerated dockerignore file has to explicitly list every file in he
monorepo as a reverse match which eventually got so big something broke
internally to docker.

New script will not autogen the dockerignore file if its committed to
git. This PR includes a manually crafted one for avm-transpiler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initial Archiver AztecProtocol/aztec-packages
3 participants
@benesjan @iAmMichaelConnor @PhilWindle