Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: move memory trace building related functions into a dedicated class #3834

Closed
jeanmon opened this issue Jan 4, 2024 · 0 comments
Closed

Refactoring: move memory trace building related functions into a dedicated class #3834

jeanmon opened this issue Jan 4, 2024 · 0 comments
Assignees
@jeanmon
Labels
C-avm Component: AVM related tickets (aka public VM)

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Jan 4, 2024

No description provided.

@jeanmon jeanmon added the C-avm Component: AVM related tickets (aka public VM) label Jan 4, 2024
@jeanmon jeanmon self-assigned this Jan 4, 2024
@jeanmon jeanmon added this to A3 Jan 4, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Jan 4, 2024
@jeanmon jeanmon moved this from Todo to In Progress in A3 Jan 4, 2024
@jeanmon jeanmon mentioned this issue Jan 4, 2024
Merged
@jeanmon jeanmon moved this from In Progress to In Review in A3 Jan 4, 2024
jeanmon added a commit that referenced this issue Jan 5, 2024
@jeanmon
refactor(avm): avm memory trace building (#3835)
b7766d6 
Resolves #3834 

Moving all AVM memory related trace building functions into a dedicated
class.
Furthermore, all AVM related trace files were moved into a dedicated
folder in vm.
The following files:

- AvmMini_common.hpp
- AvmMini_helper.cpp
- AvmMini_helper.hpp
- AvmMini_mem_trace.cpp
- AvmMini_mem_trace.hpp
- AvmMini_trace.cpp
- AvmMini_trace.hpp
were moved from 

barretenberg/cpp/src/barretenberg/proof_system/circuit_builder/

to

barretenberg/cpp/src/barretenberg/vm/avm_trace/

Finally, the namespace for these files were migrating from proof_system
to avm_trace.
@jeanmon jeanmon closed this as completed Jan 5, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Jan 5, 2024
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@jeanmon
refactor(avm): avm memory trace building (AztecProtocol#3835)
56c34ca 
Resolves AztecProtocol#3834 

Moving all AVM memory related trace building functions into a dedicated
class.
Furthermore, all AVM related trace files were moved into a dedicated
folder in vm.
The following files:

- AvmMini_common.hpp
- AvmMini_helper.cpp
- AvmMini_helper.hpp
- AvmMini_mem_trace.cpp
- AvmMini_mem_trace.hpp
- AvmMini_trace.cpp
- AvmMini_trace.hpp
were moved from 

barretenberg/cpp/src/barretenberg/proof_system/circuit_builder/

to

barretenberg/cpp/src/barretenberg/vm/avm_trace/

Finally, the namespace for these files were migrating from proof_system
to avm_trace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanmon jeanmon

Labels
C-avm Component: AVM related tickets (aka public VM)
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeanmon