refactor(avm): avm memory trace building

[jeanmon]

Resolves #3834

Moving all AVM memory related trace building functions into a dedicated class.
Furthermore, all AVM related trace files were moved into a dedicated folder in vm.
The following files:

• AvmMini_common.hpp
• AvmMini_helper.cpp
• AvmMini_helper.hpp
• AvmMini_mem_trace.cpp
• AvmMini_mem_trace.hpp
• AvmMini_trace.cpp
• AvmMini_trace.hpp
  were moved from

barretenberg/cpp/src/barretenberg/proof_system/circuit_builder/

to

barretenberg/cpp/src/barretenberg/vm/avm_trace/

Finally, the namespace for these files were migrating from proof_system to avm_trace.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_history_successful_decrypting_time_in_ms (5): 2,982 (+18%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit a60b71a5 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,984	868,184	3,449,444
l1_rollup_execution_gas	842,071	3,595,292	22,205,106
l2_block_processing_time_in_ms	1,332 (-1%)	5,122	20,647 (-3%)
note_successful_decrypting_time_in_ms	337 (-2%)	1,046 (-6%)	3,801 (-1%)
note_trial_decrypting_time_in_ms	47.9 (-10%)	41.6 (+11%)	142 (+3%)
l2_block_building_time_in_ms	13,511	53,613 (-1%)	216,093 (-1%)
l2_block_rollup_simulation_time_in_ms	9,981	39,676 (-1%)	160,323
l2_block_public_tx_process_time_in_ms	3,497 (-1%)	13,867	55,491 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	16,160 (+1%)	30,638 (+4%)
note_history_successful_decrypting_time_in_ms	⚠️ 2,982 (+18%)	5,488 (+8%)
note_history_trial_decrypting_time_in_ms	107 (+26%)	153 (+9%)
node_database_size_in_bytes	3,905,903	4,253,359
pxe_database_size_in_bytes	29,940	59,499

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	200	43,109	20,441
private-kernel-ordering	115	25,833	9,689
base-rollup	2,056	244,144	881
root-rollup	87.0 (-1%)	4,088	889
private-kernel-inner	260	64,516	20,441
public-kernel-private-input	171 (-1%)	25,203	20,441
public-kernel-non-first-iteration	170 (-1%)	25,245	20,441
merge-rollup	11.3 (-1%)	2,608	881

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	10,323	26,359

[Maddiaa0]

lgtm, only real suggestion would be to consolidate all of the code in the vm folder.

[Maddiaa0]

nit: missing doc on @return

[jeanmon]

Very good catch! I addressed it.