chore!: Remove aggregation objects from RecursionConstraint

[vezenovm]

This removes the aggregation objects which are currently unused in the RecursionConstraint implementation. Next we will update the ACVM opcode to no longer use the aggregation object fields and update the serialization.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

• If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
• I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
• Every change is related to the PR description.
• I have linked this pull request to relevant issues (if any exist).

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_successful_decrypting_time_in_ms (8): 525 (+39%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 217de090 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	223,032	868,028	3,449,672
l1_rollup_execution_gas	867,141	3,746,081	23,306,437
l2_block_processing_time_in_ms	1,366 (+3%)	5,154 (+1%)	21,547 (+3%)
note_successful_decrypting_time_in_ms	⚠️ 525 (+39%)	1,256 (+13%)	4,254 (+3%)
note_trial_decrypting_time_in_ms	33.3 (-62%)	40.2 (+5%)	140
l2_block_building_time_in_ms	15,239 (+2%)	60,380 (+2%)	242,933 (+2%)
l2_block_rollup_simulation_time_in_ms	10,896 (+3%)	43,150 (+2%)	174,137 (+2%)
l2_block_public_tx_process_time_in_ms	4,310 (+1%)	17,097 (+1%)	68,407 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,197 (-1%)	29,102
note_history_successful_decrypting_time_in_ms	2,925 (-1%)	5,292 (-4%)
note_history_trial_decrypting_time_in_ms	95.7 (+2%)	171 (+15%)
node_database_size_in_bytes	3,619,256	3,729,312
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	211	44,709	25,561
private-kernel-ordering	137	30,953	14,809
base-rollup	1,092 (+1%)	128,374	881
root-rollup	82.6	4,088	889
private-kernel-inner	287	71,236	25,561
public-kernel-private-input	203	31,891	25,561
public-kernel-non-first-iteration	201	31,933	25,561
merge-rollup	9.72	2,608	881

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,487	31,877

[kevaundray]

I think we need to modify the double verify proof example and the relevant code that was assuming an aggregation object

[vezenovm]

I think we need to modify the double verify proof example and the relevant code that was assuming an aggregation object

I can do that. I wasn't sure do this PR being up on Noir (noir-lang/noir#3909). The same updates to double_verify_proof from the Noir PR were done in this repo here (https://github.com/AztecProtocol/aztec-packages/pull/3744/files#diff-077262f84958ac3f4aefffdde6b96c5dbe1fbb18710f155d1dbec8ed2e44d8ab). Should I just change the std::verify_proof interface as well? I was thinking to have be for a separate PR as this PR is mainly serialization changes.