feat: contract inclusion proof

[benesjan]

1. Fixes Implement inclusion proof of a contract in contracts tree #3465
2. Fixes feat: Prove contract inclusion with constructor args #3695
3. naming consistency fix in get sibling path methods,
4. refactored the e2e test and each type of proof is now in a nested describe statement.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

• If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
• I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
• Every change is related to the PR description.
• I have linked this pull request to relevant issues (if any exist).

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 1be03af9 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,996	867,800	3,449,600
l1_rollup_execution_gas	842,083	3,594,908	22,205,262
l2_block_processing_time_in_ms	1,357	5,148	21,247 (-7%)
note_successful_decrypting_time_in_ms	352 (+1%)	1,080 (+1%)	3,993 (-10%)
note_trial_decrypting_time_in_ms	62.8 (+8%)	38.6 (+1%)	137 (-21%)
l2_block_building_time_in_ms	13,582	53,760	217,558 (-5%)
l2_block_rollup_simulation_time_in_ms	10,034 (+1%)	39,755	161,104 (-4%)
l2_block_public_tx_process_time_in_ms	3,518	13,936	56,214 (-5%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,872 (+1%)	29,817
note_history_successful_decrypting_time_in_ms	2,820 (+2%)	5,281 (+7%)
note_history_trial_decrypting_time_in_ms	163 (-2%)	136 (-34%)
node_database_size_in_bytes	3,920,975	4,251,846
pxe_database_size_in_bytes	29,940	59,499

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	200	43,109	20,441
private-kernel-ordering	115 (-1%)	25,833	9,689
base-rollup	2,058 (-1%)	244,144	881
root-rollup	85.3	4,088	889
private-kernel-inner	261 (-1%)	64,516	20,441
public-kernel-private-input	172 (-2%)	25,203	20,441
public-kernel-non-first-iteration	171 (-1%)	25,245	20,441
merge-rollup	11.2 (-1%)	2,608	881

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	10,323	26,359

[LHerskind]

If you add the ref to the issue mentioned I think this is good 👍

[LHerskind]

Think this is good, tiny comments.

[LHerskind]

For my mental image, it still made more sense to me that it was the constructor hash actually combining all the things and not just the vk hash. Bu as @iAmMichaelConnor mentioned they he desire to change how contracts are deployed anyway, don't seem worth it to look deeper into that now.

[benesjan]

it still made more sense to me that it was the constructor hash actually combining all the things and not just the vk hash.

Maybe I misunderstood but the constructor hash is actually "combining all the things" since part of its preimage is the constructor vk hash (see this code).

This change I did didn't break anything because wherever the incorrectly named constructorHash value was used it actually represented the constructorVkHash. Here is where the value is assigned.