Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: contract inclusion proof #3680
feat: contract inclusion proof #3680
Changes from 10 commits
b378931
4bf6b27
2bf06d7
1b88d1d
d4da60d
40ec8a3
3485b03
bdbaf9c
9237488
1f878be
9563410
c6483ae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my mental image, it still made more sense to me that it was the constructor hash actually combining all the things and not just the vk hash. Bu as @iAmMichaelConnor mentioned they he desire to change how contracts are deployed anyway, don't seem worth it to look deeper into that now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I misunderstood but the constructor hash is actually "combining all the things" since part of its preimage is the constructor vk hash (see this code).
This change I did didn't break anything because wherever the incorrectly named constructorHash value was used it actually represented the constructorVkHash. Here is where the value is assigned.