chore(dsl): Abstract nested aggregation object from ACIR

[vezenovm]

The nested aggregation object in a RecursionConstraint is currently not used at the Noir level at all. We want to enable having the user specify whether the proof they want to verify is itself a recursive proof, but we also do not want to have an explicit field on the opcode determining this as this would be a barretenberg leakage into the ACVM recursion opcode.

We instead move to having the proof field in the recursion constraint adhere to a barretenberg specific structure, where the expected proof should be stripped of its public inputs, except in the case where we have a nested proof. When setting up the barretenberg circuit from ACIR we can then determine how the nested_aggregation_object constant indices should be set from the size of the proof object.

Until the recursive verifier can move to an implementation where the nested aggregation object does not have to be a circuit constant we need the user to specify whether they want to aggregation over a nested proof. If we move to not requiring these circuit constants we can have the proof inputs to the recursive aggregation builtin be the same for both use cases.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

• If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
• I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
• Every change is related to the PR description.
• I have linked this pull request to relevant issues (if any exist).

[AztecBot]

Benchmark results

Metrics with a significant change:

• node_database_size_in_bytes (10): 5,821,595 (+38%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 5c6c2caf and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,972	868,124	3,448,280
l1_rollup_execution_gas	842,059	3,595,232	22,203,942
l2_block_processing_time_in_ms	1,326	5,069 (-4%)	20,931
note_successful_decrypting_time_in_ms	342	1,136 (+8%)	3,762 (-1%)
note_trial_decrypting_time_in_ms	53.5 (-1%)	43.2 (+15%)	136 (+1%)
l2_block_building_time_in_ms	13,625	53,715	217,107
l2_block_rollup_simulation_time_in_ms	10,073 (+1%)	39,730	160,658
l2_block_public_tx_process_time_in_ms	3,523	13,920	56,215

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,453 (-4%)	29,565 (-1%)
note_history_successful_decrypting_time_in_ms	2,669 (+2%)	4,776 (-1%)
note_history_trial_decrypting_time_in_ms	74.7 (-32%)	183 (-10%)
node_database_size_in_bytes	3,917,491	⚠️ 5,821,595 (+38%)
pxe_database_size_in_bytes	29,940	59,499

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	200	43,109	20,441
private-kernel-ordering	114 (-1%)	25,833	9,689
base-rollup	2,059	244,144	881
root-rollup	84.1 (-1%)	4,088	889
private-kernel-inner	261	64,516	20,441
public-kernel-private-input	173 (+1%)	25,203	20,441
public-kernel-non-first-iteration	170 (-1%)	25,245	20,441
merge-rollup	9.66 (-3%)	2,608	881

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	10,323	26,309

[kevaundray]

I think we should rename this to be something like recursion_proof_size_without_public_inputs