Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: update install script #3846

Closed
Tracked by #2658
critesjosh opened this issue Jan 5, 2024 · 0 comments · Fixed by #3847
Closed
Tracked by #2658

Docs: update install script #3846

critesjosh opened this issue Jan 5, 2024 · 0 comments · Fixed by #3847
Assignees
@critesjosh
Labels
A-documentation Area: relates to documentation

Comments

@critesjosh
Copy link
Contributor

  • Update the references to the install scripts in the docs according to the info here
    • small difference is to use aztec-nargo compile to compile and artifact and typescript generation using aztec-cli (eg aztec-cli generate-typescript target --outdir src/artifacts)
  • Remove references to installing nargo
  • remove any remaining references to npm
@critesjosh critesjosh self-assigned this Jan 5, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Jan 5, 2024
@critesjosh critesjosh added the A-documentation Area: relates to documentation label Jan 5, 2024
This was referenced Jan 5, 2024
Closed
Merged
critesjosh added a commit that referenced this issue Jan 9, 2024
@critesjosh
chore(docs): Update install script (#3847)
7003853 
Updates the docker install script to get the sandbox, cli and nargo.

~~just verify that the LSP works with aztec-nargo. suggestions to
install nargo have been removed.~~
EDIT: I added the recommendation to install nargo back in for the LSP.

Closes: #3846 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 9, 2024
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@critesjosh
chore(docs): Update install script (AztecProtocol#3847)
1a1b477 
Updates the docker install script to get the sandbox, cli and nargo.

~~just verify that the LSP works with aztec-nargo. suggestions to
install nargo have been removed.~~
EDIT: I added the recommendation to install nargo back in for the LSP.

Closes: AztecProtocol#3846 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@critesjosh critesjosh

Labels
A-documentation Area: relates to documentation
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(docs): Update install script AztecProtocol/aztec-packages
1 participant
@critesjosh