Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(MessageBoxes): Prune data send in process #5073

Closed
Tracked by #4492
LHerskind opened this issue Mar 8, 2024 · 0 comments · Fixed by #5272
Closed
Tracked by #4492

refactor(MessageBoxes): Prune data send in process #5073

LHerskind opened this issue Mar 8, 2024 · 0 comments · Fixed by #5272
Assignees
@benesjan

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Mar 8, 2024 •
edited
Loading

When the inbox and outbox are both implemented, we can remove the _body part of the process function as it now receive enough information directly in the header.

This means that the MessageDecoder which is currently only taking care of the body can be removed all-together.

Note: Look for "TODO(#5073)" in the codebase.
@github-project-automation github-project-automation bot moved this to Todo in A3 Mar 8, 2024
@LHerskind LHerskind mentioned this issue Mar 8, 2024
Closed
@LHerskind LHerskind changed the title feat(MessageBoxes): Prune data send in process refactor(MessageBoxes): Prune data send in process Mar 8, 2024
@sklppy88 sklppy88 self-assigned this Mar 20, 2024
This was referenced Mar 20, 2024
Closed
Merged
@benesjan benesjan mentioned this issue Mar 21, 2024
Merged
@benesjan benesjan assigned benesjan and unassigned sklppy88 Mar 21, 2024
@benesjan benesjan moved this from Todo to In Progress in A3 Mar 21, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: nuking l1 to l2 messages from block body AztecProtocol/aztec-packages
3 participants
@benesjan @LHerskind @sklppy88