refactor: nuking l1 to l2 messages from block body #5272

benesjan · 2024-03-17T19:06:11Z

benesjan · 2024-03-17T19:06:23Z

refactor: nuking l1 to l2 messages from block body #5272 👈
refactor: removing redundant receipts check #5271 : 1 other dependent PR (#5270 )
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

LHerskind

Good changes. Minor comments. When we have figured out why CI fails but not locally this should also be pretty good state ot go in.

l1-contracts/src/core/libraries/decoders/MessagesDecoder.sol

yarn-project/sequencer-client/src/block_builder/solo_block_builder.ts

LHerskind

Rebase and then this one should also be good 👍

AztecBot · 2024-03-19T12:22:37Z

Benchmark results

Metrics with a significant change:

l1_rollup_calldata_gas (8): 6,460 (-90%)
l1_rollup_calldata_gas (32): 6,448 (-97%)
l1_rollup_calldata_gas (64): 6,448 (-99%)
l1_rollup_calldata_size_in_bytes (8): 676 (-88%)
l1_rollup_calldata_size_in_bytes (32): 676 (-96%)
l1_rollup_calldata_size_in_bytes (64): 676 (-98%)
l1_rollup_execution_gas (32): 582,685 (-39%)
l1_rollup_execution_gas (64): 582,685 (-56%)
note_trial_decrypting_time_in_ms (32): 118 (+284%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit fec10081 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	⚠️ 676 (-88%)	⚠️ 676 (-96%)	⚠️ 676 (-98%)
l1_rollup_calldata_gas	⚠️ 6,460 (-90%)	⚠️ 6,448 (-97%)	⚠️ 6,448 (-99%)
l1_rollup_execution_gas	582,697 (-14%)	⚠️ 582,685 (-39%)	⚠️ 582,685 (-56%)
l2_block_processing_time_in_ms	1,404 (+11%)	4,935 (+5%)	9,095 (-2%)
note_successful_decrypting_time_in_ms	180 (-6%)	499 (-3%)	958 (+1%)
note_trial_decrypting_time_in_ms	86.7 (-10%)	⚠️ 118 (+284%)	89.9 (+10%)
l2_block_building_time_in_ms	17,791	67,206	133,380
l2_block_rollup_simulation_time_in_ms	8,052 (+1%)	28,468	56,091
l2_block_public_tx_process_time_in_ms	9,718	38,683	77,193

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,647 (+3%)	27,794 (+1%)
note_history_successful_decrypting_time_in_ms	1,315 (+8%)	2,452
note_history_trial_decrypting_time_in_ms	95.5 (+57%)	153 (-2%)
node_database_size_in_bytes	18,661,456	34,889,808 (-1%)
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	279	44,366	28,245
private-kernel-ordering	214	52,869	14,327
base-parity	1,794 (-1%)	128	311
base-rollup	711	165,788	925
root-parity	1,594 (+3%)	1,244	311
root-rollup	51.7	4,487	725
private-kernel-inner	642	73,772	28,245
public-kernel-app-logic	429 (+1%)	35,260	28,215
public-kernel-tail	173 (+1%)	40,926	28,215
merge-rollup	8.43 (+1%)	2,696	925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.1 (+1%)	16.0	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.589 (+1%)	0.495	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	45.7	72.0	233 (+1%)	443 (-1%)	873 (+1%)	1,726 (+1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.468	0.445	0.425 (+1%)	0.415 (-1%)	0.416 (+1%)	0.414 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.2	107 (+1%)	336 (+1%)	657	1,309 (+1%)	2,618 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.480	0.482 (+1%)	0.457	0.453	0.455	0.455 (+1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.2
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.536

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	22,013

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	3,175 (-2%)	1,741 (-1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	11.9 (-9%)	1,209 (+1%)

benesjan · 2024-03-21T13:55:56Z

boxes/boxes/react/tests/node.test.ts

@@ -21,9 +21,7 @@ describe('BoxReact Contract Tests', () => {

  test('Can set a number', async () => {
    logger(`${await wallet.getRegisteredAccounts()}`);
-    const callTxReceipt = await contract.methods.setNumber(numberToSet, wallet.getCompleteAddress()).send().wait();
-
-    expect(callTxReceipt.status).toBe(TxStatus.MINED);


Forgot to nuke this one in this PR so I sneaked that in here.

benesjan · 2024-03-21T14:13:54Z