refactor: camelCase in noir-projects -> snake_case

[sklppy88]

Can we add a ci check for style on noir code so this doesn't creep back in again?

Resolves #1928.

[AztecBot]

Docs Preview

Hey there! 👋 You can check your preview at https://65fd9ee1e8ba201bdc99cc40--aztec-docs-dev.netlify.app

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit c4dce948 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,424	6,400	6,376 (-1%)
l1_rollup_execution_gas	585,757	585,733	585,709
l2_block_processing_time_in_ms	1,287	4,750	9,054 (+1%)
note_successful_decrypting_time_in_ms	176 (-2%)	522	977 (+3%)
note_trial_decrypting_time_in_ms	79.6 (-3%)	39.8 (+5%)	110 (+51%)
l2_block_building_time_in_ms	17,178 (-1%)	65,109	129,008
l2_block_rollup_simulation_time_in_ms	7,931 (-1%)	28,367	55,986 (+1%)
l2_block_public_tx_process_time_in_ms	9,227	36,688	72,927

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,811	26,653 (+4%)
note_history_successful_decrypting_time_in_ms	1,260 (+3%)	2,464 (+2%)
note_history_trial_decrypting_time_in_ms	67.3 (+13%)	192 (+25%)
node_database_size_in_bytes	18,665,552	35,082,320
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	240	44,302	28,181
private-kernel-ordering	214	52,805	14,263
base-parity	1,837	128	311
base-rollup	705	165,724	861
root-parity	1,574 (+1%)	1,244	311
root-rollup	50.1	4,359	725
private-kernel-inner	593	73,644	28,181
public-kernel-app-logic	399 (+1%)	35,164	28,151
public-kernel-tail	172 (+1%)	40,862	28,151
merge-rollup	7.08	2,568	861

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.99 (-1%)	16.0 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.582 (-1%)	0.495 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	45.9 (+1%)	72.1	230	447 (+2%)	867	1,725	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.471 (+1%)	0.445	0.421	0.418 (+2%)	0.412	0.413	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.7 (+1%)	107 (+1%)	334	666 (+3%)	1,315 (+1%)	2,611	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.477	0.482 (+1%)	0.455	0.458 (+3%)	0.455	0.454	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.2 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.536 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	21,949

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	3,086	1,643

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	10.4 (-6%)	1,144

[ludamad]

not sure how easy it is to plug in a tool to check this hmm. But thaanks for doing this

[ludamad]

I'd say we don't usually check this in other projects, might just be a case of not having any stuff that misleads people into doing camelCase, sometimes it just propagates because it's already in the code

[sklppy88]

I'd say we don't usually check this in other projects, might just be a case of not having any stuff that misleads people into doing camelCase, sometimes it just propagates because it's already in the code

Casing / other style is indirectly enforced throughout yarn-projects through eslint, maybe we could look into running some sort of nr formatter in the future ?

Thanks for the pr approval 👍