refactor: nuking L1 block number from L2 block #5275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 18, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
commented
Mar 18, 2024
|
|
||
| // create the block number -> block hash mapping to ensure we retrieve the appropriate events | ||
| const blockNumberToBodyHash: { [key: number]: Buffer | undefined } = {}; |
There was a problem hiding this comment.
This map was completely unused here.
benesjan
commented
Mar 18, 2024
| @@ -209,50 +210,50 @@ export class Archiver implements ArchiveSource { | |||
| ); | |||
|
|
|||
| const blockBodies = retrievedBlockBodies.retrievedData.map(([blockBody]) => blockBody); | |||
|
|
|||
| await this.store.addBlockBodies(blockBodies); | |||
There was a problem hiding this comment.
The code bellow here was all messy so I cleaned that up.
benesjan
force-pushed
the
03-17-refactor_nuking_l1_to_l2_messages_from_block_body
branch
from
d8b572c to
5d407f1
Compare
benesjan
force-pushed
the
03-18-refactor_nuking_L1_block_number_from_L2_block
branch
from
1348fdc to
268d641
Compare
benesjan
force-pushed
the
03-17-refactor_nuking_l1_to_l2_messages_from_block_body
branch
from
5d407f1 to
5c58881
Compare
benesjan
force-pushed
the
03-18-refactor_nuking_L1_block_number_from_L2_block
branch
from
268d641 to
8754701
Compare
LHerskind
approved these changes
Mar 18, 2024
benesjan
force-pushed
the
03-17-refactor_nuking_l1_to_l2_messages_from_block_body
branch
from
5c58881 to
e34dec8
Compare
benesjan
force-pushed
the
03-18-refactor_nuking_L1_block_number_from_L2_block
branch
from
8754701 to
422191a
Compare
benesjan
force-pushed
the
03-17-refactor_nuking_l1_to_l2_messages_from_block_body
branch
from
e34dec8 to
a1abb66
Compare
benesjan
force-pushed
the
03-18-refactor_nuking_L1_block_number_from_L2_block
branch
from
422191a to
2da0404
Compare
benesjan
force-pushed
the
03-17-refactor_nuking_l1_to_l2_messages_from_block_body
branch
from
a1abb66 to
a57663a
Compare
benesjan
force-pushed
the
03-18-refactor_nuking_L1_block_number_from_L2_block
branch
from
2da0404 to
fee8bd3
Compare
benesjan
changed the base branch from
03-17-refactor_nuking_l1_to_l2_messages_from_block_body
to
master
benesjan
force-pushed
the
03-18-refactor_nuking_L1_block_number_from_L2_block
branch
from
fee8bd3 to
b33b3d8
Compare
benesjan
changed the base branch from
master
to
03-17-refactor_l1_l2_messages_cleanup
benesjan
merged commit 6e69a6b
into
03-17-refactor_l1_l2_messages_cleanup
8 of 25 checks passed
benesjan
deleted the
03-18-refactor_nuking_L1_block_number_from_L2_block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5274