Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute_note_hash_and_nullifier errors and other note processing errors come up as warnings #5669

Closed
Tracked by #5077
rahul-kothari opened this issue Apr 10, 2024 · 2 comments · Fixed by #5838
Closed
Tracked by #5077

compute_note_hash_and_nullifier errors and other note processing errors come up as warnings #5669

rahul-kothari opened this issue Apr 10, 2024 · 2 comments · Fixed by #5838
Assignees
@Thunkar

Comments

@rahul-kothari
Copy link
Contributor

Example:

WARN Could not process note because of "Error: The note being processed has 27 fields, while "compute_note_hash_and_nullifier" can only handle a maximum of 20 fields. Please consider increasing the allowed field size to accommodate all notes generated from the contract.". Discarding note...

Actual error comes from here
Gets caught as a warning in the note processor here

These should be warnings
@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 10, 2024
@rahul-kothari rahul-kothari mentioned this issue Apr 10, 2024
Merged
rahul-kothari added a commit that referenced this issue Apr 11, 2024
@rahul-kothari
chore: compute_note_hash_and_nullifier - improve error message (#5671)
8942d69 
Also created #5669 and #5670
@LHerskind
Copy link
Contributor

I'm not following here. IS this not the same as #5670 or what is the real diff here?

@rahul-kothari
Copy link
Contributor Author

5670 -> can we have a compile time error for max note lem
this one -> in general all errors in note processor now are shown up as warnings!

@Thunkar Thunkar mentioned this issue Apr 19, 2024
Merged
@LHerskind LHerskind mentioned this issue Apr 19, 2024
Open
Thunkar added a commit that referenced this issue Apr 22, 2024
@Thunkar
chore: Improve compute_note_hash_and_nullifier autogeneration and `…
566f25c 
…NoteProcessor` warnings (#5838)

Closes #5669,
#5670,
#4649

Correctly determines the signature of the autogenerated
`compute_note_hash_and_nullifier` by looking up the serialized content
size of notes used in the contract. Furthermore, that langth is compared
against MAX_NOTE_FIELDS_LEN and a compile time error is emited if the
user attempts to use a note that is bigger than currently supported.
Finally changed the `NoteProcessor` warns to be errors (even thought
this particular one shouldn't get that far anymore!)
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Apr 22, 2024
AztecBot added a commit to noir-lang/noir that referenced this issue Apr 22, 2024
@AztecBot
chore: Improve compute_note_hash_and_nullifier autogeneration and `…
4964bc4 
…NoteProcessor` warnings (AztecProtocol/aztec-packages#5838)

Closes AztecProtocol/aztec-packages#5669,
AztecProtocol/aztec-packages#5670,
AztecProtocol/aztec-packages#4649

Correctly determines the signature of the autogenerated
`compute_note_hash_and_nullifier` by looking up the serialized content
size of notes used in the contract. Furthermore, that langth is compared
against MAX_NOTE_FIELDS_LEN and a compile time error is emited if the
user attempts to use a note that is bigger than currently supported.
Finally changed the `NoteProcessor` warns to be errors (even thought
this particular one shouldn't get that far anymore!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thunkar Thunkar

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
3 participants
@Thunkar @LHerskind @rahul-kothari