chore: Improve compute_note_hash_and_nullifier autogeneration and NoteProcessor warnings

[Thunkar]

Closes #5669, #5670, #4649

Correctly determines the signature of the autogenerated compute_note_hash_and_nullifier by looking up the serialized content size of notes used in the contract. Furthermore, that langth is compared against MAX_NOTE_FIELDS_LEN and a compile time error is emited if the user attempts to use a note that is bigger than currently supported. Finally changed the NoteProcessor warns to be errors (even thought this particular one shouldn't get that far anymore!)

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_history_trial_decrypting_time_in_ms (5): 125 (+158%)
• note_successful_decrypting_time_in_ms (8): 205 (+51%)
• note_trial_decrypting_time_in_ms (8): 94.3 (+414%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	772	772	772
l1_rollup_calldata_gas	6,844	6,832	6,832
l1_rollup_execution_gas	587,325	587,313	587,313
l2_block_processing_time_in_ms	1,573 (+2%)	5,568	10,559
note_successful_decrypting_time_in_ms	⚠️ 205 (+51%)	468 (-3%)	694 (-12%)
note_trial_decrypting_time_in_ms	⚠️ 94.3 (+414%)	65.6 (-19%)	99.6 (+2%)
l2_block_building_time_in_ms	18,892	73,430	145,921
l2_block_rollup_simulation_time_in_ms	18,686	72,668	144,392
l2_block_public_tx_process_time_in_ms	8,567 (+1%)	33,308	66,384 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	16,073	31,377 (+4%)
note_history_successful_decrypting_time_in_ms	877 (-6%)	1,790 (+1%)
note_history_trial_decrypting_time_in_ms	⚠️ 125 (+158%)	117 (-11%)
node_database_size_in_bytes	19,161,168	35,778,640
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	156	47,815	31,978
private-kernel-inner	176 (-1%)	80,846	31,978
private-kernel-ordering	136 (-1%)	57,732	49,888
base-parity	73.9 (-4%)	128	265
root-parity	129 (-2%)	1,244	265
base-rollup	12,284 (+1%)	110,926	957
root-rollup	50.1	4,551	821
public-kernel-app-logic	1,660	62,069	52,067
public-kernel-tail	4,249	168,566	7,491
merge-rollup	3,117	2,760	957
public-kernel-teardown	113 (+1%)	62,069	52,067
public-kernel-setup	119	62,069	52,067

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.0 (-1%)	17.8 (-2%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.638 (-1%)	0.551 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	51.9 (+1%)	80.2	260 (+1%)	501	979 (-1%)	1,931 (-1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.532 (+1%)	0.495	0.474 (+1%)	0.468	0.464 (-1%)	0.463	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.5	119	379 (+1%)	739	1,460 (-1%)	2,912 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.535	0.535	0.515 (+1%)	0.508	0.505 (-1%)	0.507 (-1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	67.5
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.589

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	51,450	537,961

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	897	1,145	1,345

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,297 (+3%)	867	3,510 (-1%)

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	835 (-1%)	700	1,359 (-1%)	927 (+1%)	2,084 (-1%)	1,159 (-1%)

[sirasistant]

letsgo!