Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proving Phase 2]: Update private kernel circuits to support recursive verification #5978

Closed
Tracked by #5975
PhilWindle opened this issue Apr 24, 2024 · 0 comments · Fixed by #6278
Closed
Tracked by #5975

Comments

@PhilWindle
Copy link
Collaborator

No description provided.

@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 24, 2024
@PhilWindle PhilWindle changed the title [Proving Phase 2]: Update private kernel circuits to support recursive verification (may require changes to bb.js) [Proving Phase 2]: Update private kernel circuits to support recursive verification May 8, 2024
PhilWindle added a commit that referenced this issue May 9, 2024
This PR introduces recursive verification to the private kernel
circuits. Both app circuit and previous kernel circuit proofs are
verified. This closes #5978

The changes can be largely categorised as:

1. PXE modifications to pass proofs and verification keys from the
output of a proving process as inputs to the next simulation/proving
process.
2. Serialisation of `PrivateCircuitPublicInputs` and
`PrivateKernelCircuitPublicInputs` structs to fields.
3. Aggregation of proofs using Noir's `verify_proof` api.

Additional task create
[here](#6285) to
prevent the specification of `pub` on arguments to private functions.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant