Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proving Phase 2]: Prevent contract compilation if specifying pub arguments to a private or public function #6285

Closed
Tracked by #5975
PhilWindle opened this issue May 8, 2024 · 0 comments · Fixed by #6355
Closed
Tracked by #5975

[Proving Phase 2]: Prevent contract compilation if specifying pub arguments to a private or public function #6285

PhilWindle opened this issue May 8, 2024 · 0 comments · Fixed by #6355

Comments

@PhilWindle
Copy link
Collaborator

No description provided.

@PhilWindle PhilWindle mentioned this issue May 8, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 May 8, 2024
@PhilWindle PhilWindle mentioned this issue May 8, 2024
Merged
PhilWindle added a commit that referenced this issue May 9, 2024
@PhilWindle
feat: Private Kernel Recursion (#6278)
eae5822 
This PR introduces recursive verification to the private kernel
circuits. Both app circuit and previous kernel circuit proofs are
verified. This closes #5978

The changes can be largely categorised as:

1. PXE modifications to pass proofs and verification keys from the
output of a proving process as inputs to the next simulation/proving
process.
2. Serialisation of `PrivateCircuitPublicInputs` and
`PrivateKernelCircuitPublicInputs` structs to fields.
3. Aggregation of proofs using Noir's `verify_proof` api.

Additional task create
[here](#6285) to
prevent the specification of `pub` on arguments to private functions.
@PhilWindle PhilWindle changed the title [Proving Phase 2]: Prevent contract compilation if specifying pub arguments to a private function [Proving Phase 2]: Prevent contract compilation if specifying pub arguments to a private or public function May 12, 2024
@PhilWindle PhilWindle moved this from Todo to In Review in A3 May 12, 2024
@PhilWindle PhilWindle mentioned this issue May 12, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 May 13, 2024
PhilWindle added a commit that referenced this issue May 14, 2024
@PhilWindle @sirasistant
fix: Check for public args in aztec functions (#6355)
219efd6 
This PR modifies the aztec macros to error if arguments with public
visibility are specified on private or public functions. Closes #6285

---------

Co-authored-by: Álvaro Rodríguez <sirasistant@gmail.com>
iakovenkos pushed a commit that referenced this issue May 15, 2024
@PhilWindle @sirasistant @iakovenkos
fix: Check for public args in aztec functions (#6355)
4eba118 
This PR modifies the aztec macros to error if arguments with public
visibility are specified on private or public functions. Closes #6285

---------

Co-authored-by: Álvaro Rodríguez <sirasistant@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Check for public args in aztec functions AztecProtocol/aztec-packages
1 participant
@PhilWindle