Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Batch simulate #6549

Closed
Tracked by #5077
Thunkar opened this issue May 21, 2024 · 0 comments · Fixed by #6599
Closed
Tracked by #5077

feat: Batch simulate #6549

Thunkar opened this issue May 21, 2024 · 0 comments · Fixed by #6599
Assignees

Comments

@Thunkar
Copy link
Contributor

Thunkar commented May 21, 2024

Allow batched .simulate calls from aztec.js to improve speed and remove as many unconstrained getters as possible

@Thunkar Thunkar self-assigned this May 21, 2024
@Thunkar Thunkar added this to A3 May 21, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 May 21, 2024
This was referenced May 21, 2024
Thunkar added a commit that referenced this issue May 23, 2024
Closes: #6549

Also removes `FunctionData` from `TxExecutionRequest` and a bunch of
other places, in favor of just the `FunctionSelector`(which is actually
what's needed). This was missed from #3417 and was driving me crazy when
trying to add a few more things to `FunctionCall`. It had also leaked
somehow into the AVM enqueued calls.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 May 23, 2024
AztecBot pushed a commit to AztecProtocol/aztec-nr that referenced this issue May 24, 2024
Closes: AztecProtocol/aztec-packages#6549

Also removes `FunctionData` from `TxExecutionRequest` and a bunch of
other places, in favor of just the `FunctionSelector`(which is actually
what's needed). This was missed from #3417 and was driving me crazy when
trying to add a few more things to `FunctionCall`. It had also leaked
somehow into the AVM enqueued calls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant