feat(sol-honk): integrate solidity honk verifier with bb and acir tests #7573

Maddiaa0 · 2024-07-23T09:50:34Z

Overview

Updated the existing solidity testing flow to run for a number of honk tests - some with public inputs and some without.

Maddiaa0 · 2024-07-23T09:52:35Z

barretenberg/cpp/src/barretenberg/honk/utils/honk_key_gen.hpp

@@ -0,0 +1,104 @@
+#pragma once


I have thrown this in the honk/utils path as it seemed fitting, however this path only has testing code. @codygunton do you think this should stay here?

Another file like this is in barretenberg/solidity_helpers but idk exactly what makes sense

Maddiaa0 · 2024-07-23T09:55:20Z

barretenberg/acir_tests/flows/honk_sol.sh

+export PROOF_AS_FIELDS="$(pwd)/proof_fields.json"
+
+# Create a proof, write the solidity contract, write the proof as fields in order to extract the public inputs
+$BIN prove_keccak_ultra_honk -o proof


I have included a second bb command that uses the UltraKeccak flavor for proving, in its current form this is not very user friendly.

Maddiaa0 · 2024-07-23T09:57:09Z

barretenberg/acir_tests/sol-test/src/index.js

-  const proofStr = `0x${proof.toString("hex").substring(64 * numPublicInputs)}`;
+  // Cut the number of public inputs out of the proof string
+  let proofStr = proof.toString("hex");
+  if (testingHonk) {


The verifier's interface is verify(proof, publicInputs[]). However, in it's current form honk proofs have 3 elements before the public inputs, so I (and the user) will need to slice these out in order to have proofs which can be processed by the verifier.

I did not want to change the serialization of the proofs in this pr, but it is something to think about ahead of the noir switch over

Maddiaa0 · 2024-07-23T09:58:23Z

barretenberg/sol/src/honk/instance/Add2Honk.sol

@@ -25,30 +25,6 @@ import {ecMul, ecAdd, ecSub, negateInplace, convertProofPoint} from "../utils.so
 // Field arithmetic libraries
 import {Fr, FrLib} from "../Fr.sol";

-struct Proof {


As proof sizes are fixed in the current form, the proof struct can be shared across instances, hence its deletion.

The remaining changes in the solidity files are majority formatting changes

AztecBot · 2024-07-23T19:59:31Z

Benchmark results

Metrics with a significant change:

protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 4,016 (-41%)
protocol_circuit_witness_generation_time_in_ms (public-kernel-tail): 20,358 (-26%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,717	1,547	704	759 (+1%)	774 (+1%)
proof_construction_time_sha256_30_ms	11,779 (+1%)	3,153	1,412	1,429	1,469
proof_construction_time_sha256_100_ms	43,794	11,987 (+2%)	5,457 (+1%)	5,411	5,359
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	59.0	88.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,517	418	203 (+2%)	232 (+5%)	270 (+2%)
proof_construction_time_poseidon_hash_100_ms	5,617	1,505 (-1%)	674 (-1%)	733 (+2%)	744

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	708	708	708
l1_rollup_calldata_gas	6,564	6,594	6,600
l1_rollup_execution_gas	583,026	583,207	583,364
l2_block_processing_time_in_ms	766	1,426 (+1%)	2,712 (+1%)
l2_block_building_time_in_ms	13,130	25,535	50,529 (-1%)
l2_block_rollup_simulation_time_in_ms	13,130	25,535	50,529 (-1%)
l2_block_public_tx_process_time_in_ms	11,035	23,225	48,144 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,138 (+1%)	9,934 (+1%)
node_database_size_in_bytes	12,771,408	16,908,368
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	116	417 (+3%)	21,732	54,085	N/A	N/A	N/A	N/A
private-kernel-inner	227 (-1%)	747 (+3%)	81,199	54,264	N/A	N/A	N/A	N/A
private-kernel-tail	1,118 (-1%)	2,502	61,568	62,127	N/A	N/A	N/A	N/A
base-parity	6.64 (+2%)	832 (+1%)	160	96.0	1,334 (-8%)	12,676	3.00	131,072
root-parity	107	109 (-14%)	64,860	96.0	27,753 (-12%)	12,676	3.00	4,194,304
base-rollup	4,182	5,127 (+2%)	181,083	632	41,060 (-10%)	13,476	28.0	4,194,304
root-rollup	154 (+1%)	111 (-12%)	51,261	652	25,219 (-14%)	13,412	26.0	4,194,304
public-kernel-setup	196 (-2%)	2,348 (-4%)	113,048	80,822	15,604 (-14%)	119,428	3,339	2,097,152
public-kernel-app-logic	151	3,234 (-3%)	113,048	80,822	8,772 (-14%)	119,428	3,339	1,048,576
public-kernel-tail	892	⚠️ 20,358 (-26%)	410,181	10,814	61,717 (-10%)	25,860	415	8,388,608
private-kernel-reset-tiny	306 (+2%)	1,042 (+3%)	77,007	53,954	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	⚠️ 4,016 (-41%)	2,916	773,262	1,632	N/A	N/A	N/A	N/A
public-kernel-teardown	140 (-3%)	3,297 (-2%)	113,048	80,822	16,171 (-14%)	119,428	3,339	2,097,152
merge-rollup	57.2	N/A	33,566	632	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	172,746 (-1%)	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,312	9,344	399 (+1%)	N/A	N/A
ContractInstanceDeployer:deploy	1,376	9,344	25.5 (+1%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	9,344	646 (+1%)	N/A	N/A
GasToken:deploy	1,344	9,344	571 (+1%)	N/A	N/A
SchnorrAccount:constructor	1,280	9,344	467 (+2%)	N/A	N/A
SchnorrAccount:entrypoint	2,272	9,344	802 (+1%)	N/A	N/A
Token:privately_mint_private_note	1,248	9,344	566 (+4%)	N/A	N/A
FPC:fee_entrypoint_public	1,312	9,344	105 (+6%)	N/A	N/A
Token:transfer	1,280	9,344	1,563 (+2%)	N/A	N/A
AuthRegistry:set_authorized (avm)	19,222	N/A	N/A	95,392	2,382 (+4%)
FPC:prepare_fee (avm)	22,670	N/A	N/A	95,456	2,458 (+7%)
Token:transfer_public (avm)	42,914	N/A	N/A	95,456	3,176 (+1%)
AuthRegistry:consume (avm)	33,100	N/A	N/A	95,424	2,975 (+4%)
FPC:pay_refund (avm)	32,835	N/A	N/A	95,424	7,922 (-11%)
Benchmarking:create_note	1,312	9,344	443 (-2%)	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	9,344	42.3	N/A	N/A
Token:unshield	1,344	9,344	1,234	N/A	N/A
FPC:fee_entrypoint_private	1,344	9,344	1,616 (+1%)	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	98.6 (+1%)	13,790
GasToken:set_portal	13.1 (+27%)	3,339
Token:constructor	124 (+2%)	23,692
FPC:constructor	93.2 (+2%)	13,592
GasToken:mint_public	82.1 (-1%)	10,158
Token:mint_public	342 (+3%)	19,034
Token:assert_minter_and_mint	50.8 (+1%)	12,925
AuthRegistry:set_authorized	44.0 (-2%)	7,812
FPC:prepare_fee	106 (+2%)	11,068
Token:transfer_public	37.7 (-21%)	31,218
FPC:pay_refund	123 (+2%)	21,266
Benchmarking:increment_balance	1,297	11,281
Token:_increase_public_balance	15.5 (+2%)	15,006
FPC:pay_refund_with_shielded_rebate	179 (+2%)	22,361

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.158 (-1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.5 (+1%)	16.8 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.604 (+1%)	0.517 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.5	75.9	132 (+1%)	247 (+1%)	471
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.495	0.466	0.452 (+1%)	0.446 (+1%)	0.440
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.5 (+2%)	112 (+1%)	184 (+1%)	354 (+1%)	695 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.510 (+1%)	0.501 (+1%)	0.485 (+1%)	0.479 (+1%)	0.477
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	73.4 (+1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.522 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	77,362	668,542

Transaction size based on fee payment method

| Metric | |
| - | |

AztecBot

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite	Current: `241508e`	Previous: `ba365c0`	Ratio
`nativeClientIVCBench/Full/6`	`14219.871842999994` ms/iter	`13300.881290000007` ms/iter	`1.07`
`wasmClientIVCBench/Full/6`	`42200.995354000006` ms/iter	`39728.2553` ms/iter	`1.06`
`commit(t)`	`4789014775` ns/iter	`3649675717` ns/iter	`1.31`
`commit(t)`	`3942986247` ns/iter	`3649675717` ns/iter	`1.08`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton

github-actions · 2024-07-25T10:07:20Z

Changes to circuit sizes

Generated at commit: 90ee64f21f2f8d04da55e9c42623ff15f4907771, compared to commit: 840486e5ce6b41d6c873239de108b3731dd81101

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
public_kernel_tail	+639 ❌	+0.07%	+639 ❌	+0.01%
rollup_base	+196 ❌	+0.06%	+117 ❌	+0.00%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
public_kernel_tail	965,693 (+639)	+0.07%	4,645,487 (+639)	+0.01%
rollup_base	341,542 (+196)	+0.06%	3,836,142 (+117)	+0.00%

codygunton

Updated Github config to run the new tests and they pass. LGTM

codygunton · 2024-07-25T09:23:12Z

barretenberg/acir_tests/flows/honk_sol.sh

+export PROOF_AS_FIELDS="$(pwd)/proof_fields.json"
+
+# Create a proof, write the solidity contract, write the proof as fields in order to extract the public inputs
+$BIN prove_keccak_ultra_honk -o proof


codygunton · 2024-07-25T09:37:59Z

barretenberg/sol/src/honk/Transcript.sol

@@ -26,7 +26,6 @@ struct Transcript {
    Fr zmQuotient;
    // Derived
    Fr publicInputsDelta;


This entity was deleted but it has 20 vestiges in the code still; adding issue to clean up here
AztecProtocol/barretenberg#1061

codygunton · 2024-07-25T09:47:32Z

.github/workflows/ci.yml

+      - name: "BB Solidity Acir Tests"
+        working-directory: ./barretenberg/
+        timeout-minutes: 40
+        run: earthly-ci --no-output ./+barretenberg-acir-tests-sol


This line is a mistake; it's running the wrong job

codygunton · 2024-07-25T11:48:10Z

barretenberg/cpp/src/barretenberg/honk/utils/honk_key_gen.hpp

@@ -0,0 +1,104 @@
+#pragma once


Another file like this is in barretenberg/solidity_helpers but idk exactly what makes sense

codygunton · 2024-07-25T11:48:42Z

barretenberg/cpp/src/barretenberg/honk/utils/honk_key_gen.hpp

@@ -92,21 +95,10 @@ inline void output_vk_sol_ultra_honk(
    print_g1(key->lagrange_first, "lagrangeFirst");
    print_g1(key->lagrange_last, "lagrangeLast", /*last=*/ true);
    os <<


Nb this will need to be reinstated when we have reinstated

codygunton · 2024-07-25T11:50:01Z

barretenberg/cpp/src/barretenberg/bb/main.cpp

+ * - stdout: The Solidity verifier contract is written to stdout as a string
+ * - Filesystem: The Solidity verifier contract is written to the path specified by outputPath
+ *
+ * Note: The fact that the contract was computed is for an ACIR circuit is not of importance


Typo: note unclear

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.47.1</summary> ## [0.47.1](aztec-package-v0.47.0...aztec-package-v0.47.1) (2024-07-30) ### Features * Do not evict tx objects from p2p tx pool immediately ([#7652](#7652)) ([96492dc](96492dc)) * Min and max block times for sequencer ([#7630](#7630)) ([2a013b8](2a013b8)) * Transaction sender bot ([#7586](#7586)) ([176fd08](176fd08)), closes [#7562](#7562) ### Bug Fixes * Aztec start --prover ([#7617](#7617)) ([ac206a6](ac206a6)) ### Miscellaneous * Add tx bot to terraform ([#7609](#7609)) ([6caa914](6caa914)) * Merge Devnet back to Master ([#7611](#7611)) ([112961c](112961c)) </details> <details><summary>barretenberg.js: 0.47.1</summary> ## [0.47.1](barretenberg.js-v0.47.0...barretenberg.js-v0.47.1) (2024-07-30) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.47.1</summary> ## [0.47.1](aztec-packages-v0.47.0...aztec-packages-v0.47.1) (2024-07-30) ### Features * Add recursive aggregation object to proving/verification keys ([#6770](#6770)) ([f48b069](f48b069)) * Adding aggregation to honk and rollup ([#7466](#7466)) ([2633aa9](2633aa9)) * Allow get_notes to return zero notes ([#7621](#7621)) ([e16452a](e16452a)) * **avm:** Pedersen commit in avm ([#7634](#7634)) ([45e7867](45e7867)) * **avm:** Pedersen commitment sim ([#7632](#7632)) ([cc420a0](cc420a0)) * Do not evict tx objects from p2p tx pool immediately ([#7652](#7652)) ([96492dc](96492dc)) * Handle L1toL2 msgs in prover-node ([#7654](#7654)) ([f35bac5](f35bac5)) * Leonidas ([#7597](#7597)) ([eda498a](eda498a)) * Min and max block times for sequencer ([#7630](#7630)) ([2a013b8](2a013b8)) * **sol-honk:** Integrate solidity honk verifier with bb and acir tests ([#7573](#7573)) ([344ca6f](344ca6f)) * **sol-honk:** Test verifying recursive proof ([#7576](#7576)) ([26408c1](26408c1)) * Static.aztec.network ([#7649](#7649)) ([9dffef5](9dffef5)) * Transaction sender bot ([#7586](#7586)) ([176fd08](176fd08)), closes [#7562](#7562) ### Bug Fixes * Aztec start --prover ([#7617](#7617)) ([ac206a6](ac206a6)) * Bb mac build ([#7619](#7619)) ([e3c5602](e3c5602)) * Faucet correctly derives its account ([#7645](#7645)) ([921773f](921773f)) * Uniswap e2e test "nonce too low" ([#7633](#7633)) ([e9e2318](e9e2318)) ### Miscellaneous * Add tx bot to terraform ([#7609](#7609)) ([6caa914](6caa914)) * **bb readme:** Add installation instructions and TODOs ([#7601](#7601)) ([1a97698](1a97698)) * **bb readme:** Update versioning instructions and add Honk Solidity verifier commands ([#7608](#7608)) ([9dd9195](9dd9195)) * Bench client ivc proof verification ([#7553](#7553)) ([b060309](b060309)) * Call requests ([#7483](#7483)) ([ffedf39](ffedf39)) * Constant inputs for most blackboxes ([#7613](#7613)) ([3247058](3247058)) * **docs:** Fix links ([#7602](#7602)) ([f2029be](f2029be)) * Merge Devnet back to Master ([#7611](#7611)) ([112961c](112961c)) * **p2p:** Tx serialization cleanup ([#7620](#7620)) ([022a899](022a899)) * Replace relative paths to noir-protocol-circuits ([ebaafc7](ebaafc7)) * Replace relative paths to noir-protocol-circuits ([d3b818d](d3b818d)) * Replace relative paths to noir-protocol-circuits ([4a26a19](4a26a19)) </details> <details><summary>barretenberg: 0.47.1</summary> ## [0.47.1](barretenberg-v0.47.0...barretenberg-v0.47.1) (2024-07-30) ### Features * Add recursive aggregation object to proving/verification keys ([#6770](#6770)) ([f48b069](f48b069)) * Adding aggregation to honk and rollup ([#7466](#7466)) ([2633aa9](2633aa9)) * **avm:** Pedersen commit in avm ([#7634](#7634)) ([45e7867](45e7867)) * **avm:** Pedersen commitment sim ([#7632](#7632)) ([cc420a0](cc420a0)) * **sol-honk:** Integrate solidity honk verifier with bb and acir tests ([#7573](#7573)) ([344ca6f](344ca6f)) * **sol-honk:** Test verifying recursive proof ([#7576](#7576)) ([26408c1](26408c1)) ### Bug Fixes * Bb mac build ([#7619](#7619)) ([e3c5602](e3c5602)) ### Miscellaneous * **bb readme:** Add installation instructions and TODOs ([#7601](#7601)) ([1a97698](1a97698)) * **bb readme:** Update versioning instructions and add Honk Solidity verifier commands ([#7608](#7608)) ([9dd9195](9dd9195)) * Call requests ([#7483](#7483)) ([ffedf39](ffedf39)) * Constant inputs for most blackboxes ([#7613](#7613)) ([3247058](3247058)) * Merge Devnet back to Master ([#7611](#7611)) ([112961c](112961c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.47.1</summary> ## [0.47.1](AztecProtocol/aztec-packages@aztec-package-v0.47.0...aztec-package-v0.47.1) (2024-07-30) ### Features * Do not evict tx objects from p2p tx pool immediately ([#7652](AztecProtocol/aztec-packages#7652)) ([96492dc](AztecProtocol/aztec-packages@96492dc)) * Min and max block times for sequencer ([#7630](AztecProtocol/aztec-packages#7630)) ([2a013b8](AztecProtocol/aztec-packages@2a013b8)) * Transaction sender bot ([#7586](AztecProtocol/aztec-packages#7586)) ([176fd08](AztecProtocol/aztec-packages@176fd08)), closes [#7562](AztecProtocol/aztec-packages#7562) ### Bug Fixes * Aztec start --prover ([#7617](AztecProtocol/aztec-packages#7617)) ([ac206a6](AztecProtocol/aztec-packages@ac206a6)) ### Miscellaneous * Add tx bot to terraform ([#7609](AztecProtocol/aztec-packages#7609)) ([6caa914](AztecProtocol/aztec-packages@6caa914)) * Merge Devnet back to Master ([#7611](AztecProtocol/aztec-packages#7611)) ([112961c](AztecProtocol/aztec-packages@112961c)) </details> <details><summary>barretenberg.js: 0.47.1</summary> ## [0.47.1](AztecProtocol/aztec-packages@barretenberg.js-v0.47.0...barretenberg.js-v0.47.1) (2024-07-30) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.47.1</summary> ## [0.47.1](AztecProtocol/aztec-packages@aztec-packages-v0.47.0...aztec-packages-v0.47.1) (2024-07-30) ### Features * Add recursive aggregation object to proving/verification keys ([#6770](AztecProtocol/aztec-packages#6770)) ([f48b069](AztecProtocol/aztec-packages@f48b069)) * Adding aggregation to honk and rollup ([#7466](AztecProtocol/aztec-packages#7466)) ([2633aa9](AztecProtocol/aztec-packages@2633aa9)) * Allow get_notes to return zero notes ([#7621](AztecProtocol/aztec-packages#7621)) ([e16452a](AztecProtocol/aztec-packages@e16452a)) * **avm:** Pedersen commit in avm ([#7634](AztecProtocol/aztec-packages#7634)) ([45e7867](AztecProtocol/aztec-packages@45e7867)) * **avm:** Pedersen commitment sim ([#7632](AztecProtocol/aztec-packages#7632)) ([cc420a0](AztecProtocol/aztec-packages@cc420a0)) * Do not evict tx objects from p2p tx pool immediately ([#7652](AztecProtocol/aztec-packages#7652)) ([96492dc](AztecProtocol/aztec-packages@96492dc)) * Handle L1toL2 msgs in prover-node ([#7654](AztecProtocol/aztec-packages#7654)) ([f35bac5](AztecProtocol/aztec-packages@f35bac5)) * Leonidas ([#7597](AztecProtocol/aztec-packages#7597)) ([eda498a](AztecProtocol/aztec-packages@eda498a)) * Min and max block times for sequencer ([#7630](AztecProtocol/aztec-packages#7630)) ([2a013b8](AztecProtocol/aztec-packages@2a013b8)) * **sol-honk:** Integrate solidity honk verifier with bb and acir tests ([#7573](AztecProtocol/aztec-packages#7573)) ([344ca6f](AztecProtocol/aztec-packages@344ca6f)) * **sol-honk:** Test verifying recursive proof ([#7576](AztecProtocol/aztec-packages#7576)) ([26408c1](AztecProtocol/aztec-packages@26408c1)) * Static.aztec.network ([#7649](AztecProtocol/aztec-packages#7649)) ([9dffef5](AztecProtocol/aztec-packages@9dffef5)) * Transaction sender bot ([#7586](AztecProtocol/aztec-packages#7586)) ([176fd08](AztecProtocol/aztec-packages@176fd08)), closes [#7562](AztecProtocol/aztec-packages#7562) ### Bug Fixes * Aztec start --prover ([#7617](AztecProtocol/aztec-packages#7617)) ([ac206a6](AztecProtocol/aztec-packages@ac206a6)) * Bb mac build ([#7619](AztecProtocol/aztec-packages#7619)) ([e3c5602](AztecProtocol/aztec-packages@e3c5602)) * Faucet correctly derives its account ([#7645](AztecProtocol/aztec-packages#7645)) ([921773f](AztecProtocol/aztec-packages@921773f)) * Uniswap e2e test "nonce too low" ([#7633](AztecProtocol/aztec-packages#7633)) ([e9e2318](AztecProtocol/aztec-packages@e9e2318)) ### Miscellaneous * Add tx bot to terraform ([#7609](AztecProtocol/aztec-packages#7609)) ([6caa914](AztecProtocol/aztec-packages@6caa914)) * **bb readme:** Add installation instructions and TODOs ([#7601](AztecProtocol/aztec-packages#7601)) ([1a97698](AztecProtocol/aztec-packages@1a97698)) * **bb readme:** Update versioning instructions and add Honk Solidity verifier commands ([#7608](AztecProtocol/aztec-packages#7608)) ([9dd9195](AztecProtocol/aztec-packages@9dd9195)) * Bench client ivc proof verification ([#7553](AztecProtocol/aztec-packages#7553)) ([b060309](AztecProtocol/aztec-packages@b060309)) * Call requests ([#7483](AztecProtocol/aztec-packages#7483)) ([ffedf39](AztecProtocol/aztec-packages@ffedf39)) * Constant inputs for most blackboxes ([#7613](AztecProtocol/aztec-packages#7613)) ([3247058](AztecProtocol/aztec-packages@3247058)) * **docs:** Fix links ([#7602](AztecProtocol/aztec-packages#7602)) ([f2029be](AztecProtocol/aztec-packages@f2029be)) * Merge Devnet back to Master ([#7611](AztecProtocol/aztec-packages#7611)) ([112961c](AztecProtocol/aztec-packages@112961c)) * **p2p:** Tx serialization cleanup ([#7620](AztecProtocol/aztec-packages#7620)) ([022a899](AztecProtocol/aztec-packages@022a899)) * Replace relative paths to noir-protocol-circuits ([ebaafc7](AztecProtocol/aztec-packages@ebaafc7)) * Replace relative paths to noir-protocol-circuits ([d3b818d](AztecProtocol/aztec-packages@d3b818d)) * Replace relative paths to noir-protocol-circuits ([4a26a19](AztecProtocol/aztec-packages@4a26a19)) </details> <details><summary>barretenberg: 0.47.1</summary> ## [0.47.1](AztecProtocol/aztec-packages@barretenberg-v0.47.0...barretenberg-v0.47.1) (2024-07-30) ### Features * Add recursive aggregation object to proving/verification keys ([#6770](AztecProtocol/aztec-packages#6770)) ([f48b069](AztecProtocol/aztec-packages@f48b069)) * Adding aggregation to honk and rollup ([#7466](AztecProtocol/aztec-packages#7466)) ([2633aa9](AztecProtocol/aztec-packages@2633aa9)) * **avm:** Pedersen commit in avm ([#7634](AztecProtocol/aztec-packages#7634)) ([45e7867](AztecProtocol/aztec-packages@45e7867)) * **avm:** Pedersen commitment sim ([#7632](AztecProtocol/aztec-packages#7632)) ([cc420a0](AztecProtocol/aztec-packages@cc420a0)) * **sol-honk:** Integrate solidity honk verifier with bb and acir tests ([#7573](AztecProtocol/aztec-packages#7573)) ([344ca6f](AztecProtocol/aztec-packages@344ca6f)) * **sol-honk:** Test verifying recursive proof ([#7576](AztecProtocol/aztec-packages#7576)) ([26408c1](AztecProtocol/aztec-packages@26408c1)) ### Bug Fixes * Bb mac build ([#7619](AztecProtocol/aztec-packages#7619)) ([e3c5602](AztecProtocol/aztec-packages@e3c5602)) ### Miscellaneous * **bb readme:** Add installation instructions and TODOs ([#7601](AztecProtocol/aztec-packages#7601)) ([1a97698](AztecProtocol/aztec-packages@1a97698)) * **bb readme:** Update versioning instructions and add Honk Solidity verifier commands ([#7608](AztecProtocol/aztec-packages#7608)) ([9dd9195](AztecProtocol/aztec-packages@9dd9195)) * Call requests ([#7483](AztecProtocol/aztec-packages#7483)) ([ffedf39](AztecProtocol/aztec-packages@ffedf39)) * Constant inputs for most blackboxes ([#7613](AztecProtocol/aztec-packages#7613)) ([3247058](AztecProtocol/aztec-packages@3247058)) * Merge Devnet back to Master ([#7611](AztecProtocol/aztec-packages#7611)) ([112961c](AztecProtocol/aztec-packages@112961c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Maddiaa0 added 30 commits February 27, 2024 23:39

feat(honk): verifier start

fa6a841

temp

fabd169

Merge branch 'master' into md/02-26-feat_honk_verifier_start

43cd61a

temp - get it compiling

323e7b0

Merge branch 'master' into md/02-26-feat_honk_verifier_start

ff22c01

temp

1ed41cb

temp 2

78d45b0

feat: fiat shamir complete

b7881f1

feat: experiment with a custom Fr type

a724d30

feat: oink verifier stages

dd85f2d

feat: arith, perm, lookup, gen perm relation

538f432

feat: field inversions

654ab55

feat: elliptic relation

b9fe7ba

feat: sumcheck complete

7f94eb2

feat: start zm

b510ca8

feat: more zm

1da70e0

feat: honk verification

6c5da89

chore: remove logs for gas accounting

d131397

🧹

b914b69

🧹

1443210

🧹

ecd7af6

🧹

2f9a5d0

chore: add verifier for 3 circuit types

60e2a7a

fix: fix fuzz tests

56c28fb

fix: add extra check and invert checkSum result

3f5a478

Merge branch 'master' into md/02-26-feat_honk_verifier_start

f08a0ec

temp

9d7a651

fix: Update honk implementation: add logderiv, scaled etas

10a8eea

fix

b2e9eee

Merge branch 'master' into md/02-26-feat_honk_verifier_start

eaa1c0e

Maddiaa0 added 8 commits July 21, 2024 14:24

fix: clean up comments

4d26743

fix: remove box commit

d2906cf

temp

ebf730a

feat: run acir tests through honk solidity verifier

f48e25b

feat: add to earthly

2547a1e

fix: cleanup codegen + earthly

9205a31

fix: update keygen

5363e3a

Merge branch 'master' into md/sol-honk-codegen

2ab22da

Maddiaa0 commented Jul 23, 2024

View reviewed changes

Maddiaa0 requested a review from codygunton July 23, 2024 09:53

Maddiaa0 commented Jul 23, 2024

View reviewed changes

Maddiaa0 added 3 commits July 23, 2024 10:09

chore: regenerate keys after merge

cdfe6d6

fix: rm file

af20b64

Merge branch 'master' into md/sol-honk-codegen

61d2278

Update ci.yml to run tests

241508e

AztecBot reviewed Jul 25, 2024

View reviewed changes

codygunton approved these changes Jul 25, 2024

View reviewed changes

codygunton merged commit 344ca6f into master Jul 25, 2024
95 checks passed

codygunton deleted the md/sol-honk-codegen branch July 25, 2024 11:51

AztecBot mentioned this pull request Jul 25, 2024

chore(master): Release 0.47.1 #7605

Merged

Savio-Sou mentioned this pull request Jul 25, 2024

Document bb commands #7600

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(sol-honk): integrate solidity honk verifier with bb and acir tests #7573

feat(sol-honk): integrate solidity honk verifier with bb and acir tests #7573

Maddiaa0 commented Jul 23, 2024

Maddiaa0 Jul 23, 2024

codygunton Jul 25, 2024

Maddiaa0 Jul 23, 2024

codygunton Jul 25, 2024

Maddiaa0 Jul 23, 2024

Maddiaa0 Jul 23, 2024

AztecBot commented Jul 23, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

AztecBot left a comment

github-actions bot commented Jul 25, 2024

codygunton left a comment

codygunton Jul 25, 2024

codygunton Jul 25, 2024

codygunton Jul 25, 2024

Maddiaa0 Jul 25, 2024

codygunton Jul 25, 2024

codygunton Jul 25, 2024

codygunton Jul 25, 2024

feat(sol-honk): integrate solidity honk verifier with bb and acir tests #7573

feat(sol-honk): integrate solidity honk verifier with bb and acir tests #7573

Conversation

Maddiaa0 commented Jul 23, 2024

Overview

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AztecBot commented Jul 23, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

AztecBot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

github-actions bot commented Jul 25, 2024

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

codygunton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AztecBot commented Jul 23, 2024 •

edited

Loading